minidump/minidump_string_writer.h - Issue 654933002: Use exactly one of final, override, and virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_string_writer.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_string_writer.h

diff --git a/minidump/minidump_string_writer.h b/minidump/minidump_string_writer.h

index 9f5fceb8b20ed5f21fbee72fd6a66f4a02a899e2..237d0d363940067e3d68a63317653b67c60ffcff 100644

--- a/minidump/minidump_string_writer.h

+++ b/minidump/minidump_string_writer.h

@@ -60,9 +60,9 @@ class MinidumpStringWriter : public MinidumpWritable {

typedef typename Traits::MinidumpStringType MinidumpStringType;

typedef typename Traits::StringType StringType;

- virtual bool Freeze() override;

- virtual size_t SizeOfObject() override;

- virtual bool WriteObject(FileWriterInterface* file_writer) override;

+ bool Freeze() override;

+ size_t SizeOfObject() override;

+ bool WriteObject(FileWriterInterface* file_writer) override;

//! \brief Sets the string to be written.

//!

« no previous file with comments | « minidump/minidump_stream_writer.h ('k') | minidump/minidump_system_info_writer.h » ('j') | no next file with comments »