Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: minidump/minidump_module_writer.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_misc_info_writer.h ('k') | minidump/minidump_stream_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_module_writer.h
diff --git a/minidump/minidump_module_writer.h b/minidump/minidump_module_writer.h
index 401a5bdc2dcf3def24ff9922fc3a72c3f933d3b9..a745f16cf600bdb2b4d6bf09f52dbf2bc2a11192 100644
--- a/minidump/minidump_module_writer.h
+++ b/minidump/minidump_module_writer.h
@@ -66,8 +66,8 @@ class MinidumpModuleCodeViewRecordPDBLinkWriter
virtual ~MinidumpModuleCodeViewRecordPDBLinkWriter();
// MinidumpWritable:
- virtual size_t SizeOfObject() override;
- virtual bool WriteObject(FileWriterInterface* file_writer) override;
+ size_t SizeOfObject() override;
+ bool WriteObject(FileWriterInterface* file_writer) override;
//! \brief Returns a pointer to the raw CodeView record’s data.
//!
@@ -154,9 +154,9 @@ class MinidumpModuleMiscDebugRecordWriter final
protected:
// MinidumpWritable:
- virtual bool Freeze() override;
- virtual size_t SizeOfObject() override;
- virtual bool WriteObject(FileWriterInterface* file_writer) override;
+ bool Freeze() override;
+ size_t SizeOfObject() override;
+ bool WriteObject(FileWriterInterface* file_writer) override;
private:
IMAGE_DEBUG_MISC image_debug_misc_;
@@ -273,10 +273,10 @@ class MinidumpModuleWriter final : public internal::MinidumpWritable {
protected:
// MinidumpWritable:
- virtual bool Freeze() override;
- virtual size_t SizeOfObject() override;
- virtual std::vector<MinidumpWritable*> Children() override;
- virtual bool WriteObject(FileWriterInterface* file_writer) override;
+ bool Freeze() override;
+ size_t SizeOfObject() override;
+ std::vector<MinidumpWritable*> Children() override;
+ bool WriteObject(FileWriterInterface* file_writer) override;
private:
MINIDUMP_MODULE module_;
@@ -304,13 +304,13 @@ class MinidumpModuleListWriter final : public internal::MinidumpStreamWriter {
protected:
// MinidumpWritable:
- virtual bool Freeze() override;
- virtual size_t SizeOfObject() override;
- virtual std::vector<MinidumpWritable*> Children() override;
- virtual bool WriteObject(FileWriterInterface* file_writer) override;
+ bool Freeze() override;
+ size_t SizeOfObject() override;
+ std::vector<MinidumpWritable*> Children() override;
+ bool WriteObject(FileWriterInterface* file_writer) override;
// MinidumpStreamWriter:
- virtual MinidumpStreamType StreamType() const override;
+ MinidumpStreamType StreamType() const override;
private:
MINIDUMP_MODULE_LIST module_list_base_;
« no previous file with comments | « minidump/minidump_misc_info_writer.h ('k') | minidump/minidump_stream_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698