Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Side by Side Diff: snapshot/system_snapshot_mac.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/memory_snapshot_mac.h ('k') | snapshot/system_snapshot_mac_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 //! \n\n 51 //! \n\n
52 //! This parameter is necessary for TimeZone() to determine whether 52 //! This parameter is necessary for TimeZone() to determine whether
53 //! daylight saving time was in effect at the time the snapshot was taken. 53 //! daylight saving time was in effect at the time the snapshot was taken.
54 //! Otherwise, it would need to base its determination on the current 54 //! Otherwise, it would need to base its determination on the current
55 //! time, which may be different than the snapshot time for snapshots 55 //! time, which may be different than the snapshot time for snapshots
56 //! generated around the daylight saving transition time. 56 //! generated around the daylight saving transition time.
57 void Initialize(ProcessReader* process_reader, const timeval* snapshot_time); 57 void Initialize(ProcessReader* process_reader, const timeval* snapshot_time);
58 58
59 // SystemSnapshot: 59 // SystemSnapshot:
60 60
61 virtual CPUArchitecture GetCPUArchitecture() const override; 61 CPUArchitecture GetCPUArchitecture() const override;
62 virtual uint32_t CPURevision() const override; 62 uint32_t CPURevision() const override;
63 virtual uint8_t CPUCount() const override; 63 uint8_t CPUCount() const override;
64 virtual std::string CPUVendor() const override; 64 std::string CPUVendor() const override;
65 virtual void CPUFrequency(uint64_t* current_hz, 65 void CPUFrequency(uint64_t* current_hz, uint64_t* max_hz) const override;
66 uint64_t* max_hz) const override; 66 uint32_t CPUX86Signature() const override;
67 virtual uint32_t CPUX86Signature() const override; 67 uint64_t CPUX86Features() const override;
68 virtual uint64_t CPUX86Features() const override; 68 uint64_t CPUX86ExtendedFeatures() const override;
69 virtual uint64_t CPUX86ExtendedFeatures() const override; 69 uint32_t CPUX86Leaf7Features() const override;
70 virtual uint32_t CPUX86Leaf7Features() const override; 70 bool CPUX86SupportsDAZ() const override;
71 virtual bool CPUX86SupportsDAZ() const override; 71 OperatingSystem GetOperatingSystem() const override;
72 virtual OperatingSystem GetOperatingSystem() const override; 72 bool OSServer() const override;
73 virtual bool OSServer() const override; 73 void OSVersion(
74 virtual void OSVersion(int* major, 74 int* major, int* minor, int* bugfix, std::string* build) const override;
75 int* minor, 75 std::string OSVersionFull() const override;
76 int* bugfix, 76 bool NXEnabled() const override;
77 std::string* build) const override; 77 std::string MachineDescription() const override;
78 virtual std::string OSVersionFull() const override; 78 void TimeZone(DaylightSavingTimeStatus* dst_status,
79 virtual bool NXEnabled() const override; 79 int* standard_offset_seconds,
80 virtual std::string MachineDescription() const override; 80 int* daylight_offset_seconds,
81 virtual void TimeZone(DaylightSavingTimeStatus* dst_status, 81 std::string* standard_name,
82 int* standard_offset_seconds, 82 std::string* daylight_name) const override;
83 int* daylight_offset_seconds,
84 std::string* standard_name,
85 std::string* daylight_name) const override;
86 83
87 private: 84 private:
88 std::string os_version_full_; 85 std::string os_version_full_;
89 std::string os_version_build_; 86 std::string os_version_build_;
90 ProcessReader* process_reader_; // weak 87 ProcessReader* process_reader_; // weak
91 const timeval* snapshot_time_; // weak 88 const timeval* snapshot_time_; // weak
92 int os_version_major_; 89 int os_version_major_;
93 int os_version_minor_; 90 int os_version_minor_;
94 int os_version_bugfix_; 91 int os_version_bugfix_;
95 bool os_server_; 92 bool os_server_;
96 InitializationStateDcheck initialized_; 93 InitializationStateDcheck initialized_;
97 94
98 DISALLOW_COPY_AND_ASSIGN(SystemSnapshotMac); 95 DISALLOW_COPY_AND_ASSIGN(SystemSnapshotMac);
99 }; 96 };
100 97
101 } // namespace internal 98 } // namespace internal
102 } // namespace crashpad 99 } // namespace crashpad
103 100
104 #endif // CRASHPAD_SNAPSHOT_SYSTEM_SNAPSHOT_MAC_H_ 101 #endif // CRASHPAD_SNAPSHOT_SYSTEM_SNAPSHOT_MAC_H_
OLDNEW
« no previous file with comments | « snapshot/memory_snapshot_mac.h ('k') | snapshot/system_snapshot_mac_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698