Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: minidump/minidump_system_info_writer.h

Issue 654933002: Use exactly one of final, override, and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: git grep -E '^ {3,}.*override[ Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_string_writer.h ('k') | minidump/minidump_thread_writer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 //! This is only valid if SetCPUArchitecture() has been used to set the CPU 159 //! This is only valid if SetCPUArchitecture() has been used to set the CPU
160 //! architecture to an architecture other than #kMinidumpCPUArchitectureX86 160 //! architecture to an architecture other than #kMinidumpCPUArchitectureX86
161 //! or #kMinidumpCPUArchitectureX86Win64. 161 //! or #kMinidumpCPUArchitectureX86Win64.
162 //! 162 //!
163 //! \note This method may be called if SetCPUArchitecture() has been used to 163 //! \note This method may be called if SetCPUArchitecture() has been used to
164 //! set the CPU architecture to #kMinidumpCPUArchitectureAMD64. 164 //! set the CPU architecture to #kMinidumpCPUArchitectureAMD64.
165 void SetCPUOtherFeatures(uint64_t features_0, uint64_t features_1); 165 void SetCPUOtherFeatures(uint64_t features_0, uint64_t features_1);
166 166
167 protected: 167 protected:
168 // MinidumpWritable: 168 // MinidumpWritable:
169 virtual bool Freeze() override; 169 bool Freeze() override;
170 virtual size_t SizeOfObject() override; 170 size_t SizeOfObject() override;
171 virtual std::vector<MinidumpWritable*> Children() override; 171 std::vector<MinidumpWritable*> Children() override;
172 virtual bool WriteObject(FileWriterInterface* file_writer) override; 172 bool WriteObject(FileWriterInterface* file_writer) override;
173 173
174 // MinidumpStreamWriter: 174 // MinidumpStreamWriter:
175 virtual MinidumpStreamType StreamType() const override; 175 MinidumpStreamType StreamType() const override;
176 176
177 private: 177 private:
178 MINIDUMP_SYSTEM_INFO system_info_; 178 MINIDUMP_SYSTEM_INFO system_info_;
179 scoped_ptr<internal::MinidumpUTF16StringWriter> csd_version_; 179 scoped_ptr<internal::MinidumpUTF16StringWriter> csd_version_;
180 180
181 DISALLOW_COPY_AND_ASSIGN(MinidumpSystemInfoWriter); 181 DISALLOW_COPY_AND_ASSIGN(MinidumpSystemInfoWriter);
182 }; 182 };
183 183
184 } // namespace crashpad 184 } // namespace crashpad
185 185
186 #endif // CRASHPAD_MINIDUMP_MINIDUMP_SYSTEM_INFO_WRITER_H_ 186 #endif // CRASHPAD_MINIDUMP_MINIDUMP_SYSTEM_INFO_WRITER_H_
OLDNEW
« no previous file with comments | « minidump/minidump_string_writer.h ('k') | minidump/minidump_thread_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698