Use exactly one of final, override, and virtual

minidump/minidump_module_writer.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 48 matching lines @@
     : public MinidumpModuleCodeViewRecordWriter {
  public:
   //! \brief Sets the name of the `.pdb` file being linked to.
   void SetPDBName(const std::string& pdb_name) { pdb_name_ = pdb_name; }
 
  protected:
   MinidumpModuleCodeViewRecordPDBLinkWriter();
   virtual ~MinidumpModuleCodeViewRecordPDBLinkWriter();
 
   // MinidumpWritable:
-  virtual size_t SizeOfObject() override;
-  virtual bool WriteObject(FileWriterInterface* file_writer) override;
+  size_t SizeOfObject() override;
+  bool WriteObject(FileWriterInterface* file_writer) override;
 
   //! \brief Returns a pointer to the raw CodeView record’s data.
   //!
   //! Subclasses can use this to set fields in their codeview records other than
   //! the `pdb_name` field.
   CodeViewRecordType* codeview_record() { return &codeview_record_; }
 
  private:
   CodeViewRecordType codeview_record_;
   std::string pdb_name_;
@@ skipping 66 matching lines @@
   //!     IMAGE_DEBUG_MISC::Unicode.
   //!
   //! If \a utf16 is `true`, \a data will be treated as UTF-8 data and will be
   //! converted to UTF-16, and IMAGE_DEBUG_MISC::Unicode will be set to `1`.
   //! Otherwise, \a data will be used as-is and IMAGE_DEBUG_MISC::Unicode will
   //! be set to `0`.
   void SetData(const std::string& data, bool utf16);
 
  protected:
   // MinidumpWritable:
-  virtual bool Freeze() override;
-  virtual size_t SizeOfObject() override;
-  virtual bool WriteObject(FileWriterInterface* file_writer) override;
+  bool Freeze() override;
+  size_t SizeOfObject() override;
+  bool WriteObject(FileWriterInterface* file_writer) override;
 
  private:
   IMAGE_DEBUG_MISC image_debug_misc_;
   std::string data_;
   string16 data_utf16_;
 
   DISALLOW_COPY_AND_ASSIGN(MinidumpModuleMiscDebugRecordWriter);
 };
 
 //! \brief The writer for a MINIDUMP_MODULE object in a minidump file.
@@ skipping 96 matching lines @@
   //!     "IMAGE_DEBUG_MISC::VersionInfo::dwFileType" and \ref
   //!     VS_FIXEDFILEINFO::dwFileSubtype
   //!     "IMAGE_DEBUG_MISC::VersionInfo::dwFileSubtype".
   void SetFileTypeAndSubtype(uint32_t file_type, uint32_t file_subtype) {
     module_.VersionInfo.dwFileType = file_type;
     module_.VersionInfo.dwFileSubtype = file_subtype;
   }
 
  protected:
   // MinidumpWritable:
-  virtual bool Freeze() override;
-  virtual size_t SizeOfObject() override;
-  virtual std::vector<MinidumpWritable*> Children() override;
-  virtual bool WriteObject(FileWriterInterface* file_writer) override;
+  bool Freeze() override;
+  size_t SizeOfObject() override;
+  std::vector<MinidumpWritable*> Children() override;
+  bool WriteObject(FileWriterInterface* file_writer) override;
 
  private:
   MINIDUMP_MODULE module_;
   scoped_ptr<internal::MinidumpUTF16StringWriter> name_;
   MinidumpModuleCodeViewRecordWriter* codeview_record_;  // weak
   MinidumpModuleMiscDebugRecordWriter* misc_debug_record_;  // weak
 
   DISALLOW_COPY_AND_ASSIGN(MinidumpModuleWriter);
 };
 
 //! \brief The writer for a MINIDUMP_MODULE_LIST stream in a minidump file,
 //!     containing a list of MINIDUMP_MODULE objects.
 class MinidumpModuleListWriter final : public internal::MinidumpStreamWriter {
  public:
   MinidumpModuleListWriter();
   ~MinidumpModuleListWriter();
 
   //! \brief Adds a MinidumpModuleWriter to the MINIDUMP_MODULE_LIST.
   //!
   //! \a module will become a child of this object in the overall tree of
   //! internal::MinidumpWritable objects.
   //!
   //! \note Valid in #kStateMutable.
   void AddModule(MinidumpModuleWriter* module);
 
  protected:
   // MinidumpWritable:
-  virtual bool Freeze() override;
-  virtual size_t SizeOfObject() override;
-  virtual std::vector<MinidumpWritable*> Children() override;
-  virtual bool WriteObject(FileWriterInterface* file_writer) override;
+  bool Freeze() override;
+  size_t SizeOfObject() override;
+  std::vector<MinidumpWritable*> Children() override;
+  bool WriteObject(FileWriterInterface* file_writer) override;
 
   // MinidumpStreamWriter:
-  virtual MinidumpStreamType StreamType() const override;
+  MinidumpStreamType StreamType() const override;
 
  private:
   MINIDUMP_MODULE_LIST module_list_base_;
   std::vector<MinidumpModuleWriter*> modules_;  // weak
 
   DISALLOW_COPY_AND_ASSIGN(MinidumpModuleListWriter);
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_MINIDUMP_MINIDUMP_MODULE_WRITER_H_