Issue 654873002: Fold away SVGInlineTextBoxPainter::paintDecorationWithStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 654873002: Fold away SVGInlineTextBoxPainter::paintDecorationWithStyle (Closed)

Created:
6 years, 2 months ago by fs

Modified:
6 years, 2 months ago

Reviewers:
pdr., f(malita), Stephen Chennney

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Fold away SVGInlineTextBoxPainter::paintDecorationWithStyle The geometry is the same in both the stroke and the fill case, which means it can be hoisted into the caller (paintDecoration). That leaves only some fairly trivial code in paintDecorationWithStyle, so fold it up entirely. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183705

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -41 lines)			Patch
	M	Source/core/paint/SVGInlineTextBoxPainter.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/paint/SVGInlineTextBoxPainter.cpp	View		3 chunks	+39 lines, -40 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654873002/1

6 years, 2 months ago (2014-10-14 23:14:49 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-14 23:18:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183705

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages