Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 654863003: Revert of Create a single command buffer for GrInOrderDrawBuffer (Closed)

Created:
6 years, 2 months ago by mtklein
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Create a single command buffer for GrInOrderDrawBuffer (patchset #17 id:1240001 of https://codereview.chromium.org/628453002/) Reason for revert: Leaking memory: http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/9/steps/gm/logs/stdio Original issue's description: > Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate > all its commands interleaved in contiguous memory. GrTRecorder also > supports extra data associated with objects, so we can store arrays > inline without having to call malloc(). > > Committed: https://skia.googlesource.com/skia/+/360b6801cfd90485891d709e44cf395d527ba69e TBR=bsalomon@google.com,reed@google.com,cdalton@nvidia.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/f439c77e9cfc13a4c31b8cb580b11d6ff09d4ed4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -725 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 8 chunks +78 lines, -82 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 14 chunks +222 lines, -145 lines 0 comments Download
D src/gpu/GrTRecorder.h View 1 chunk +0 lines, -251 lines 0 comments Download
D tests/GrTRecorderTest.cpp View 1 chunk +0 lines, -245 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Create a single command buffer for GrInOrderDrawBuffer
6 years, 2 months ago (2014-10-14 21:28:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654863003/1
6 years, 2 months ago (2014-10-14 21:29:13 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 21:29:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as f439c77e9cfc13a4c31b8cb580b11d6ff09d4ed4

Powered by Google App Engine
This is Rietveld 408576698