Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 654843012: Windows: use SystemTimeToTzSpecificLocalTime instead of localtime_s. (Closed)

Created:
6 years, 1 month ago by ulan
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Windows: use SystemTimeToTzSpecificLocalTime instead of localtime_s. The localtime_s function produces incorrect results for russian time zone. BUG=chromium:417640 LOG=Y R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M src/base/platform/platform-win32.cc View 1 chunk +14 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
Hi Sven, could you please take a look?
6 years, 1 month ago (2014-10-27 17:08:07 UTC) #2
ulan
Redirecting to Yang.
6 years, 1 month ago (2014-10-28 08:48:47 UTC) #4
Yang
LGTM. Let's watch out for performance numbers.
6 years, 1 month ago (2014-10-28 08:53:32 UTC) #5
ulan
6 years, 1 month ago (2014-10-28 08:55:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24922 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698