Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: media/cast/net/udp_transport.cc

Issue 654843007: Cast: Increase UDP socket send buffer size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: vlog to log(warning) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/net/udp_transport.h ('k') | media/cast/net/udp_transport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/net/udp_transport.cc
diff --git a/media/cast/net/udp_transport.cc b/media/cast/net/udp_transport.cc
index fa9be469ed4a255117a2879577ecc271bf793f89..e40234f98a9a42d0c40a2213891ffb7949b5dd6e 100644
--- a/media/cast/net/udp_transport.cc
+++ b/media/cast/net/udp_transport.cc
@@ -42,6 +42,7 @@ UdpTransport::UdpTransport(
const scoped_refptr<base::SingleThreadTaskRunner>& io_thread_proxy,
const net::IPEndPoint& local_end_point,
const net::IPEndPoint& remote_end_point,
+ int32 send_buffer_size,
const CastTransportStatusCallback& status_callback)
: io_thread_proxy_(io_thread_proxy),
local_addr_(local_end_point),
@@ -54,6 +55,7 @@ UdpTransport::UdpTransport(
receive_pending_(false),
client_connected_(false),
next_dscp_value_(net::DSCP_NO_CHANGE),
+ send_buffer_size_(send_buffer_size),
status_callback_(status_callback),
bytes_sent_(0),
weak_factory_(this) {
@@ -85,6 +87,9 @@ void UdpTransport::StartReceiving(
} else {
NOTREACHED() << "Either local or remote address has to be defined.";
}
+ if (udp_socket_->SetSendBufferSize(send_buffer_size_) != net::OK) {
+ VLOG(1) << "Failed to set socket send buffer size.";
+ }
ScheduleReceiveNextPacket();
}
@@ -229,7 +234,7 @@ void UdpTransport::OnSent(const scoped_refptr<net::IOBuffer>& buf,
send_pending_ = false;
if (result < 0) {
- VLOG(1) << "Failed to send packet: " << result << ".";
+ LOG(WARNING) << "Failed to send packet: " << result << ".";
miu 2014/10/17 20:20:42 Not here! ;-) You meant to change line 91 instea
Alpha Left Google 2014/10/17 20:24:57 Doh I must be too sleepy.
}
ScheduleReceiveNextPacket();
« no previous file with comments | « media/cast/net/udp_transport.h ('k') | media/cast/net/udp_transport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698