Cast: Increase UDP socket send buffer size

media/cast/net/udp_transport.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/net/udp_transport.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 24 matching lines @@
                                                     addr1.address().end(),
                                                     addr2.address().begin());
 }
 }  // namespace
 
 UdpTransport::UdpTransport(
     net::NetLog* net_log,
     const scoped_refptr<base::SingleThreadTaskRunner>& io_thread_proxy,
     const net::IPEndPoint& local_end_point,
     const net::IPEndPoint& remote_end_point,
+    int32 send_buffer_size,

[miu, 2014/10/16 18:31:57]

s/int32/int/

     const CastTransportStatusCallback& status_callback)
     : io_thread_proxy_(io_thread_proxy),
       local_addr_(local_end_point),
       remote_addr_(remote_end_point),
       udp_socket_(new net::UDPSocket(net::DatagramSocket::DEFAULT_BIND,
                                      net::RandIntCallback(),
                                      net_log,
                                      net::NetLog::Source())),
       send_pending_(false),
       receive_pending_(false),
       client_connected_(false),
       next_dscp_value_(net::DSCP_NO_CHANGE),
+      send_buffer_size_(send_buffer_size),
       status_callback_(status_callback),
       bytes_sent_(0),
       weak_factory_(this) {
   DCHECK(!IsEmpty(local_end_point) || !IsEmpty(remote_end_point));
 }
 
 UdpTransport::~UdpTransport() {}
 
 void UdpTransport::StartReceiving(
     const PacketReceiverCallback& packet_receiver) {
@@ skipping 11 matching lines @@
   } else if (!IsEmpty(remote_addr_)) {
     if (udp_socket_->Connect(remote_addr_) < 0) {
       status_callback_.Run(TRANSPORT_SOCKET_ERROR);
       LOG(ERROR) << "Failed to connect to remote address.";
       return;
     }
     client_connected_ = true;
   } else {
     NOTREACHED() << "Either local or remote address has to be defined.";
   }
+  if (udp_socket_->SetSendBufferSize(send_buffer_size_) != net::OK) {
+    VLOG(1) << "Failed to set socket send buffer size.";

[miu, 2014/10/16 18:31:57]

Perhaps this should be LOG(WARNING) or, if we believe we are setting a value
within the allowed range for the operating system: LOG(ERROR).  Seems like with
VLOG(1) it would be too easy to accidentally conceal this error.

[Alpha Left Google, 2014/10/16 18:41:27]

Done.

+  }
 
   ScheduleReceiveNextPacket();
 }
 
 void UdpTransport::SetDscp(net::DiffServCodePoint dscp) {
   DCHECK(io_thread_proxy_->RunsTasksOnCurrentThread());
   next_dscp_value_ = dscp;
 }
 
 void UdpTransport::ScheduleReceiveNextPacket() {
@@ skipping 135 matching lines @@
   }
   ScheduleReceiveNextPacket();
 
   if (!cb.is_null()) {
     cb.Run();
   }
 }
 
 }  // namespace cast
 }  // namespace media