Mojo JS Bindings: add support for associative arrays (Mojo map type)

mojo/public/interfaces/bindings/tests/test_structs.mojom

Index: mojo/public/interfaces/bindings/tests/test_structs.mojom
diff --git a/mojo/public/interfaces/bindings/tests/test_structs.mojom b/mojo/public/interfaces/bindings/tests/test_structs.mojom
index 6af00866fec053dbc001cc1572a839ca01d6e611..127af05e9ba9285b2733c0a76717c275a7a40ec2 100644
--- a/mojo/public/interfaces/bindings/tests/test_structs.mojom
+++ b/mojo/public/interfaces/bindings/tests/test_structs.mojom
@@ -108,4 +108,20 @@ struct ScopedConstants {
   int32 f6 = ALSO_TEN;
 };
 
+// Used to verify that all possible Map key field types can be encoded and

[yzshen1, 2014/10/15 05:58:02]

int64 and uint64? :)

[hansmuller, 2014/10/15 21:45:46]

JS can't really encode 64 bit integers properly but testing 64 bit keys with
smaller values is OK. I will add that.

+// decoded successfully.
+
+struct MapFields {
+  map<bool, bool> f0;
+  map<int8, int8> f1;
+  map<uint8, uint8> f2;
+  map<int16, int16> f3;
+  map<uint16, uint16> f4;
+  map<int32, int32> f5;
+  map<uint32, uint32> f6;
+  map<float, float> f7;
+  map<double, double> f8;
+  map<string, string> f9;

[qsr, 2014/10/15 13:03:40]

Do you want to test with structs, arrays and map as values?

[hansmuller, 2014/10/15 21:45:46]

This test was just intended to verify that all possible key types worked. I've
renamed the mojom type and etc to MapKeyTypes to make it a teeny bit clearer.

I've also added a unit test for the value types you suggested. I had to leave
the following fields out for now, since the C++ bindings don't generate code
that will compile for them yet:

  // map<string, map<string, string>> f3;
  // map<string, array<map<string, string>>> f4;
  // map<string, Rect?> f5;
 

[yzshen1, 2014/10/15 22:22:13]

(Out of curiosity) I thought the C++ bindings should work? what are the
problems?

[hansmuller, 2014/10/16 20:11:04]

-  The first two fail in the cpp parser:
  File
"/builds/dev/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py",
line 117, in GetCppArrayArgWrapperType
    return _kind_to_cpp_type[kind]
KeyError: <mojom.generate.module.Kind object at 0x2d641d0>


- The third one generates code that doesn't compile:
struct MapSerializer;
       ^
../../mojo/public/cpp/bindings/lib/map_serialization.h:99:19: error: implicit
instantiation of undefined template
'mojo::internal::MapSerializer<mojo::InlinedStructPtr<mojo::test::Rect>,
mojo::test::internal::Rect_Data *, true>'
        internal::MapSerializer<MapValue, DataValue>::GetItemSize(

+};
+
 }