Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 65483002: MIPS: Add new HSeqStringGetChar instruction. (Closed)

Created:
7 years, 1 month ago by palfia
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Add new HSeqStringGetChar instruction. Port r17565 (dce7927c) Original commit message: This instruction is required for copying characters from sequential strings in the hydrogenized StringAddStub. BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=17574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
7 years, 1 month ago (2013-11-07 21:41:08 UTC) #1
Paul Lind
LGTM.
7 years, 1 month ago (2013-11-07 21:52:05 UTC) #2
palfia
7 years, 1 month ago (2013-11-07 21:59:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17574 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698