Issue 6548007: Fix bug in Heap::RecordWrites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6548007: Fix bug in Heap::RecordWrites. (Closed)

Created:
9 years, 10 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Fix bug in Heap::RecordWrites. Committed: http://code.google.com/p/v8/source/detail?r=6868

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/heap-inl.h	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 10 months ago (2011-02-21 13:47:20 UTC) #2

LGTM!

http://codereview.chromium.org/6548007/diff/1/src/heap-inl.h
File src/heap-inl.h (right):

http://codereview.chromium.org/6548007/diff/1/src/heap-inl.h#newcode287
src/heap-inl.h:287: StoreBuffer::Mark(address + start + i*kPointerSize);
Spaces around '*'.

Expand Messages | Collapse Messages