Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 654783003: Update PDFium to 1b24b69. (Closed)

Created:
6 years, 2 months ago by Peter Kasting
Modified:
6 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update PDFium to 1b24b69. The only change since the previous revision is unconditionally using static_assert in third_party/macros.h. This gets rid of the old code that used ALLOW_UNUSED and will ensure there are no conflicts of any kind as I change how the version of ALLOW_UNUSED in Chromium works. BUG=81439 TEST=none TBR=jam Committed: https://crrev.com/6820c70743002d71f11c28c99602a76d989b70b1 Cr-Commit-Position: refs/heads/master@{#299412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Peter Kasting
TBRing jam for this change since he reviewed it when it landed upstream a few ...
6 years, 2 months ago (2014-10-14 00:02:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654783003/1
6 years, 2 months ago (2014-10-14 00:03:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 01:14:06 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 01:14:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6820c70743002d71f11c28c99602a76d989b70b1
Cr-Commit-Position: refs/heads/master@{#299412}

Powered by Google App Engine
This is Rietveld 408576698