Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 654763003: Flatten the string in StringToDouble function. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Flatten the string in StringToDouble function. R=yangguo@chromium.org BUG=chromium:425551 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M src/conversions.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/conversions.cc View 1 chunk +15 lines, -13 lines 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-numbers.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-425551.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 2 months ago (2014-10-21 16:23:31 UTC) #1
Yang
On 2014/10/21 16:23:31, Dmitry Lomov (chromium) wrote: > PTAL lgtm.
6 years, 2 months ago (2014-10-22 08:05:34 UTC) #2
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-22 08:19:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698