Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: components/keyed_service/content/browser_context_keyed_base_factory.h

Issue 654753010: Refactor (Refcounted)BrowserContextKeyedServiceFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/keyed_service/content/browser_context_keyed_base_factory.h
diff --git a/components/keyed_service/content/browser_context_keyed_base_factory.h b/components/keyed_service/content/browser_context_keyed_base_factory.h
index c7603afd33e924d26ffeb1ec36622416aa12fb9c..5b13ae4e450aa7ad01b5b27b8b848e3a8d966b25 100644
--- a/components/keyed_service/content/browser_context_keyed_base_factory.h
+++ b/components/keyed_service/content/browser_context_keyed_base_factory.h
@@ -27,6 +27,11 @@ class PrefRegistrySyncable;
// RefcountedBrowserContextKeyedServiceFactory. This object describes general
// dependency management between Factories; subclasses react to lifecycle
// events and implement memory management.
+//
+// Note: this class is deprecated and should not be used and will be removed
+// once http://crbug.com/131843 and http://crbug.com/131844 are closed. If you
+// need to implement a new way to manage KeyedService lifetime, base your code
+// on KeyedServiceBaseFactory instead.
class KEYED_SERVICE_EXPORT BrowserContextKeyedBaseFactory
: public KeyedServiceBaseFactory {
public:
« no previous file with comments | « components/keyed_service.gypi ('k') | components/keyed_service/content/browser_context_keyed_base_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698