Refactor (Refcounted)BrowserContextKeyedServiceFactory

components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc

Index: components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc
diff --git a/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc b/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc
index ac0926e4e432b51a02db21e881bfadaaccfb0e08..c1262cc03632f2cc94e5aed0caef6a710b6dc515 100644
--- a/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc
+++ b/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc
@@ -5,130 +5,138 @@
 #include "components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h"
 
 #include "base/logging.h"
+#include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
+#include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "components/keyed_service/core/refcounted_keyed_service.h"
+#include "components/pref_registry/pref_registry_syncable.h"
+#include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/browser_context.h"
 
 void RefcountedBrowserContextKeyedServiceFactory::SetTestingFactory(
     content::BrowserContext* context,
     TestingFactoryFunction testing_factory) {
-  // Destroying the context may cause us to lose data about whether |context|
-  // has our preferences registered on it (since the context object itself
-  // isn't dead). See if we need to readd it once we've gone through normal
-  // destruction.
-  bool add_context = ArePreferencesSetOn(context);
-
-  // We have to go through the shutdown and destroy mechanisms because there
-  // are unit tests that create a service on a context and then change the
-  // testing service mid-test.
-  BrowserContextShutdown(context);
-  BrowserContextDestroyed(context);
-
-  if (add_context)
-    MarkPreferencesSetOn(context);
-
-  testing_factories_[context] = testing_factory;
+  RefcountedKeyedServiceFactory::SetTestingFactory(
+      context,
+      reinterpret_cast<RefcountedKeyedServiceFactory::TestingFactoryFunction>(
+          testing_factory));
 }
 
 scoped_refptr<RefcountedKeyedService>
 RefcountedBrowserContextKeyedServiceFactory::SetTestingFactoryAndUse(
     content::BrowserContext* context,
     TestingFactoryFunction testing_factory) {
-  DCHECK(testing_factory);
-  SetTestingFactory(context, testing_factory);
-  return GetServiceForBrowserContext(context, true);
+  return RefcountedKeyedServiceFactory::SetTestingFactoryAndUse(
+      context,
+      reinterpret_cast<RefcountedKeyedServiceFactory::TestingFactoryFunction>(
+          testing_factory));
 }
 
 RefcountedBrowserContextKeyedServiceFactory::
     RefcountedBrowserContextKeyedServiceFactory(
         const char* name,
         BrowserContextDependencyManager* manager)
-    : BrowserContextKeyedBaseFactory(name, manager) {}
+    : RefcountedKeyedServiceFactory(name, manager) {
+}
 
 RefcountedBrowserContextKeyedServiceFactory::
     ~RefcountedBrowserContextKeyedServiceFactory() {
-  DCHECK(mapping_.empty());
 }
 
 scoped_refptr<RefcountedKeyedService>
 RefcountedBrowserContextKeyedServiceFactory::GetServiceForBrowserContext(
     content::BrowserContext* context,
     bool create) {
-  context = GetBrowserContextToUse(context);
-  if (!context)
-    return NULL;
-
-  // NOTE: If you modify any of the logic below, make sure to update the
-  // non-refcounted version in context_keyed_service_factory.cc!
-  RefCountedStorage::const_iterator it = mapping_.find(context);
-  if (it != mapping_.end())
-    return it->second;
-
-  // Object not found.
-  if (!create)
-    return NULL;  // And we're forbidden from creating one.
-
-  // Create new object.
-  // Check to see if we have a per-BrowserContext testing factory that we should
-  // use instead of default behavior.
-  scoped_refptr<RefcountedKeyedService> service;
-  BrowserContextOverriddenTestingFunctions::const_iterator jt =
-      testing_factories_.find(context);
-  if (jt != testing_factories_.end()) {
-    if (jt->second) {
-      if (!context->IsOffTheRecord())
-        RegisterUserPrefsOnBrowserContextForTest(context);
-      service = jt->second(context);
-    }
-  } else {
-    service = BuildServiceInstanceFor(context);
-  }
-
-  Associate(context, service);
-  return service;
-}
-
-void RefcountedBrowserContextKeyedServiceFactory::Associate(
-    content::BrowserContext* context,
-    const scoped_refptr<RefcountedKeyedService>& service) {
-  DCHECK(!ContainsKey(mapping_, context));
-  mapping_.insert(std::make_pair(context, service));
+  return RefcountedKeyedServiceFactory::GetServiceForContext(context, create);
+}
+
+content::BrowserContext*
+RefcountedBrowserContextKeyedServiceFactory::GetBrowserContextToUse(
+    content::BrowserContext* context) const {
+  DCHECK(CalledOnValidThread());
+
+#ifndef NDEBUG
+  AssertContextWasntDestroyed(context);
+#endif
+
+  // Safe default for Incognito mode: no service.
+  if (context->IsOffTheRecord())
+    return nullptr;
+
+  return context;
+}
+
+void RefcountedBrowserContextKeyedServiceFactory::
+    RegisterUserPrefsOnBrowserContextForTest(content::BrowserContext* context) {
+  KeyedServiceBaseFactory::RegisterUserPrefsOnContextForTest(context);
+}
+
+bool RefcountedBrowserContextKeyedServiceFactory::
+    ServiceIsCreatedWithBrowserContext() const {
+  return KeyedServiceBaseFactory::ServiceIsCreatedWithContext();
+}
+
+bool RefcountedBrowserContextKeyedServiceFactory::ServiceIsNULLWhileTesting()
+    const {
+  return KeyedServiceBaseFactory::ServiceIsNULLWhileTesting();
 }
 
 void RefcountedBrowserContextKeyedServiceFactory::BrowserContextShutdown(
     content::BrowserContext* context) {
-  RefCountedStorage::iterator it = mapping_.find(context);
-  if (it != mapping_.end() && it->second.get())
-    it->second->ShutdownOnUIThread();
+  RefcountedKeyedServiceFactory::ContextShutdown(context);
 }
 
 void RefcountedBrowserContextKeyedServiceFactory::BrowserContextDestroyed(
     content::BrowserContext* context) {
-  // We "merely" drop our reference to the service. Hopefully this will cause
-  // the service to be destroyed. If not, oh well.
-  mapping_.erase(context);
+  RefcountedKeyedServiceFactory::ContextDestroyed(context);
+}
 
-  // For unit tests, we also remove the factory function both so we don't
-  // maintain a big map of dead pointers, but also since we may have a second
-  // object that lives at the same address (see other comments about unit tests
-  // in this file).
-  testing_factories_.erase(context);
+scoped_refptr<RefcountedKeyedService>
+RefcountedBrowserContextKeyedServiceFactory::BuildServiceInstanceFor(
+    base::SupportsUserData* context) const {
+  return BuildServiceInstanceFor(
+      static_cast<content::BrowserContext*>(context));
+}
 
-  BrowserContextKeyedBaseFactory::BrowserContextDestroyed(context);
+bool RefcountedBrowserContextKeyedServiceFactory::IsOffTheRecord(
+    base::SupportsUserData* context) const {
+  return static_cast<content::BrowserContext*>(context)->IsOffTheRecord();
 }
 
-void RefcountedBrowserContextKeyedServiceFactory::SetEmptyTestingFactory(
-    content::BrowserContext* context) {
-  SetTestingFactory(context, NULL);
+user_prefs::PrefRegistrySyncable*
+RefcountedBrowserContextKeyedServiceFactory::GetAssociatedPrefRegistry(
+    base::SupportsUserData* context) const {
+  PrefService* prefs = user_prefs::UserPrefs::Get(
+      static_cast<content::BrowserContext*>(context));
+  user_prefs::PrefRegistrySyncable* registry =
+      static_cast<user_prefs::PrefRegistrySyncable*>(
+          prefs->DeprecatedGetPrefRegistry());
+  return registry;
 }
 
-bool RefcountedBrowserContextKeyedServiceFactory::HasTestingFactory(
-    content::BrowserContext* context) {
-  return testing_factories_.find(context) != testing_factories_.end();
+base::SupportsUserData*
+RefcountedBrowserContextKeyedServiceFactory::GetContextToUse(
+    base::SupportsUserData* context) const {
+  return GetBrowserContextToUse(static_cast<content::BrowserContext*>(context));
 }
 
-void RefcountedBrowserContextKeyedServiceFactory::CreateServiceNow(
-    content::BrowserContext* context) {
-  GetServiceForBrowserContext(context, true);
+bool RefcountedBrowserContextKeyedServiceFactory::ServiceIsCreatedWithContext()
+    const {
+  return ServiceIsCreatedWithBrowserContext();
+}
+
+void RefcountedBrowserContextKeyedServiceFactory::ContextShutdown(
+    base::SupportsUserData* context) {
+  BrowserContextShutdown(static_cast<content::BrowserContext*>(context));
+}
+
+void RefcountedBrowserContextKeyedServiceFactory::ContextDestroyed(
+    base::SupportsUserData* context) {
+  BrowserContextDestroyed(static_cast<content::BrowserContext*>(context));
+}
+
+void RefcountedBrowserContextKeyedServiceFactory::RegisterPrefs(
+    user_prefs::PrefRegistrySyncable* registry) {
+  RegisterProfilePrefs(registry);
 }