Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 654713003: Fix slimming paint clipping and add a debug fill color (Closed)

Created:
6 years, 2 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Fix slimming paint clipping and add a debug fill color The Slimming Paint codepath wasn't properly adding paint offsets to the applied clip rects, causing only a fraction of text to be drawn. Also adding a debug red background to make it more obvious when we're failing to paint. Cribbed from FrameView's old paint code. BUG=423071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M Source/core/paint/BlockPainter.cpp View 2 chunks +7 lines, -5 lines 0 comments Download
M Source/core/paint/LineBoxListPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ViewDisplayList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
leviw_travelin_and_unemployed
6 years, 2 months ago (2014-10-13 22:34:41 UTC) #2
chrishtr
lgtm
6 years, 2 months ago (2014-10-13 22:42:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654713003/1
6 years, 2 months ago (2014-10-13 22:43:47 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:59:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183634

Powered by Google App Engine
This is Rietveld 408576698