Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 654683003: No subtree recalc for scrollbar pseudo classes. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

No subtree recalc for scrollbar pseudo classes. Removed a set of pseudo classes which only apply to scrollbar pseudo elements from the list of classes that require subtree recalcs. R=esprehn@chromium.org,chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184529

Patch Set 1 #

Patch Set 2 : Added tests #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased #

Patch Set 6 : Try to fix Mac rendering issues in ref-test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -10 lines) Patch
A LayoutTests/fast/css/invalidation/scrollbar-pseudo-classes.html View 1 2 3 4 5 1 chunk +113 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/scrollbar-pseudo-classes-expected.html View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 2 3 4 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
rune
6 years, 2 months ago (2014-10-17 14:16:23 UTC) #1
esprehn
lgtm
6 years, 2 months ago (2014-10-17 14:25:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654683003/1
6 years, 2 months ago (2014-10-17 14:44:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/29530)
6 years, 2 months ago (2014-10-17 16:51:28 UTC) #6
chrishtr
Where is the test for this?
6 years, 2 months ago (2014-10-17 18:44:56 UTC) #7
esprehn
On 2014/10/17 at 18:44:56, chrishtr wrote: > Where is the test for this? Err woops, ...
6 years, 2 months ago (2014-10-17 18:47:12 UTC) #8
chrishtr
On 2014/10/17 at 18:47:12, esprehn wrote: > On 2014/10/17 at 18:44:56, chrishtr wrote: > > ...
6 years, 2 months ago (2014-10-17 18:48:14 UTC) #9
rune
On 2014/10/17 18:48:14, chrishtr wrote: > On 2014/10/17 at 18:47:12, esprehn wrote: > > On ...
6 years, 2 months ago (2014-10-20 08:55:55 UTC) #10
rune
On 2014/10/20 08:55:55, rune wrote: > On 2014/10/17 18:48:14, chrishtr wrote: > > On 2014/10/17 ...
6 years, 2 months ago (2014-10-24 08:45:38 UTC) #11
dglazkov
lgtm
6 years, 2 months ago (2014-10-24 15:03:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654683003/40001
6 years, 2 months ago (2014-10-24 15:03:51 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/28457)
6 years, 2 months ago (2014-10-24 16:45:42 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654683003/100001
6 years, 1 month ago (2014-10-28 14:13:28 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 184529
6 years, 1 month ago (2014-10-28 15:15:02 UTC) #20
leviw_travelin_and_unemployed
6 years, 1 month ago (2014-10-28 16:46:12 UTC) #22
Message was sent while issue was closed.
The new test is failing on Mac :-/
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...

Powered by Google App Engine
This is Rietveld 408576698