Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 654663002: No threadsafe statics. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

No threadsafe statics. Chrome disables these for speed and code size, so we need to disable them to make sure our code is safe when used this way. int foo() { static int32_t atomic_thing; return sk_atomic_inc(&atomic_thing); } is not safe in Chrome. Making the static global is: static int32_t atomic_thing; int foo() { return sk_atomic_inc(&atomic_thing); } BUG=skia: Committed: https://skia.googlesource.com/skia/+/cad5d3e264535c919b80e1e2a85407307961f221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
6 years, 2 months ago (2014-10-13 19:05:30 UTC) #2
bungeman-skia
lgtm
6 years, 2 months ago (2014-10-13 19:07:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654663002/1
6 years, 2 months ago (2014-10-13 19:09:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as cad5d3e264535c919b80e1e2a85407307961f221
6 years, 2 months ago (2014-10-13 19:53:31 UTC) #6
mtklein
6 years, 2 months ago (2014-10-13 21:49:33 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/649343003/ by mtklein@google.com.

The reason for reverting is: Want to think about how to do this only to skialib
and not to tools (gms, tests, etc.).

Powered by Google App Engine
This is Rietveld 408576698