Chromium Code Reviews
DescriptionNo threadsafe statics.
Chrome disables these for speed and code size, so we need
to disable them to make sure our code is safe when used
this way.
int foo() {
static int32_t atomic_thing;
return sk_atomic_inc(&atomic_thing);
}
is not safe in Chrome. Making the static global is:
static int32_t atomic_thing;
int foo() {
return sk_atomic_inc(&atomic_thing);
}
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/cad5d3e264535c919b80e1e2a85407307961f221
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|
|||||||||||||||||||