Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: gin/array_buffer.h

Issue 654653005: Rewrite gin/function_template.h to use C++11 variadic templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-add assignment operator. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/array_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/array_buffer.h
diff --git a/gin/array_buffer.h b/gin/array_buffer.h
index 048a35fc61935478e61a3cf3b02010ac59579524..bb3f59ce0b1d4bbd19a3dfb23e639d930ee84fdd 100644
--- a/gin/array_buffer.h
+++ b/gin/array_buffer.h
@@ -26,6 +26,7 @@ class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
class GIN_EXPORT ArrayBuffer {
public:
ArrayBuffer();
+ ArrayBuffer(const ArrayBuffer& other);
ArrayBuffer(v8::Isolate* isolate, v8::Handle<v8::ArrayBuffer> buffer);
~ArrayBuffer();
ArrayBuffer& operator=(const ArrayBuffer& other);
@@ -39,8 +40,6 @@ class GIN_EXPORT ArrayBuffer {
scoped_refptr<Private> private_;
void* bytes_;
size_t num_bytes_;
-
- DISALLOW_COPY(ArrayBuffer);
};
template<>
@@ -52,6 +51,7 @@ struct GIN_EXPORT Converter<ArrayBuffer> {
class GIN_EXPORT ArrayBufferView {
public:
ArrayBufferView();
+ ArrayBufferView(const ArrayBufferView& other);
ArrayBufferView(v8::Isolate* isolate, v8::Handle<v8::ArrayBufferView> view);
~ArrayBufferView();
ArrayBufferView& operator=(const ArrayBufferView& other);
@@ -65,8 +65,6 @@ class GIN_EXPORT ArrayBufferView {
ArrayBuffer array_buffer_;
size_t offset_;
size_t num_bytes_;
-
- DISALLOW_COPY(ArrayBufferView);
};
template<>
« no previous file with comments | « no previous file | gin/array_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698