Issue 654653005: Rewrite gin/function_template.h to use C++11 variadic templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 654653005: Rewrite gin/function_template.h to use C++11 variadic templates. (Closed)

Created:
6 years, 2 months ago by Krzysztof Olczyk

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rewrite gin/function_template.h to use C++11 variadic templates. This results in a concise code which does not require the use of pump preprocessor. Note, this CL requires "uniform initialization", which is currently not on the list of allowed C++11 features in Chromium. This CL is for demonstration purposed for chromium-dev ML thread, the actual goal of using variadic templates has been achieved and landed without it in https://codereview.chromium.org/671433004/. BUG=

Patch Set 1 : Rewrite gin/function_template.h to use C++11 variadic templates. #

Patch Set 2 : Re-add assignment operator. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -591 lines)			Patch
M	gin/array_buffer.h	View	1	4 chunks	+2 lines, -4 lines	0 comments	Download
M	gin/array_buffer.cc	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	gin/function_template.h	View		4 chunks	+55 lines, -343 lines	0 comments	Download
D	gin/function_template.h.pump	View		1 chunk	+0 lines, -240 lines	0 comments	Download
M	gin/wrappable_unittest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Patchset #1 (id:1) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages