Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4038)

Unified Diff: chrome/browser/spellchecker/spellcheck_service_unittest.cc

Issue 654653002: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a regression. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_service_unittest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service_unittest.cc b/chrome/browser/spellchecker/spellcheck_service_unittest.cc
index 5d30455befc4524baaa55063c137df89b1bda1b9..b28d7ea3a98855ce9fd105e69c5d09e2333396c2 100644
--- a/chrome/browser/spellchecker/spellcheck_service_unittest.cc
+++ b/chrome/browser/spellchecker/spellcheck_service_unittest.cc
@@ -41,7 +41,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
+ accept_languages, &languages);
EXPECT_EQ(1U, languages.size());
EXPECT_EQ("en-US", languages[0]);
@@ -54,7 +54,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
+ accept_languages, &languages);
EXPECT_EQ(1U, languages.size());
EXPECT_EQ("en-US", languages[0]);
@@ -68,7 +68,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "en-US", &languages);
+ accept_languages, &languages);
EXPECT_EQ(2U, languages.size());
@@ -85,7 +85,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
groby-ooo-7-16 2015/03/03 17:54:34 There don't seem to be any tests for the return va
- accept_languages, "en-US", &languages);
+ accept_languages, &languages);
EXPECT_EQ(2U, languages.size());
@@ -103,7 +103,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) {
std::vector<std::string> languages;
SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
- accept_languages, "fr", &languages);
+ accept_languages, &languages);
EXPECT_EQ(1U, languages.size());
EXPECT_EQ("fr", languages[0]);

Powered by Google App Engine
This is Rietveld 408576698