 Chromium Code Reviews
 Chromium Code Reviews Issue 654653002:
  Enables the user to select multiple languages for spellchecking (UI)  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 654653002:
  Enables the user to select multiple languages for spellchecking (UI)  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/spellchecker/spellcheck_service.h | 
| diff --git a/chrome/browser/spellchecker/spellcheck_service.h b/chrome/browser/spellchecker/spellcheck_service.h | 
| index 46a081bc1faed06a2c4c59c6f8dc590f65c34113..e1d24c71821421bfe82b1db9cabe38792bdf6153 100644 | 
| --- a/chrome/browser/spellchecker/spellcheck_service.h | 
| +++ b/chrome/browser/spellchecker/spellcheck_service.h | 
| @@ -56,17 +56,18 @@ class SpellcheckService : public KeyedService, | 
| // This function computes a vector of strings which are to be displayed in | 
| // the context menu over a text area for changing spell check languages. It | 
| - // returns the index of the current spell check language in the vector. | 
| + // returns the set of indices of the current spell check languages in the | 
| 
groby-ooo-7-16
2015/03/03 17:54:34
nit: can you change "in the vector" to "in |langua
 | 
| + // vector. | 
| // TODO(port): this should take a vector of base::string16, but the | 
| // implementation has some dependencies in l10n util that need porting first. | 
| - static int GetSpellCheckLanguages(content::BrowserContext* context, | 
| - std::vector<std::string>* languages); | 
| + static std::set<int> GetSpellCheckLanguages( | 
| 
groby-ooo-7-16
2015/03/03 17:54:34
Is there a particular reason to make it a set? Wou
 | 
| + content::BrowserContext* context, | 
| + std::vector<std::string>* languages); | 
| // Computes a vector of strings which are to be displayed in the context | 
| // menu from |accept_languages| and |dictionary_language|. | 
| static void GetSpellCheckLanguagesFromAcceptLanguages( | 
| const std::vector<std::string>& accept_languages, | 
| - const std::string& dictionary_language, | 
| std::vector<std::string>* languages); | 
| // Signals the event attached by AttachTestEvent() to report the specified |