chrome/browser/spellchecker/spellcheck_service_unittest.cc - Issue 654653002: Enables the user to select multiple languages for spellchecking (UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service_unittest.cc

Issue 654653002: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/spellchecker/spellcheck_factory.cc ('K') | « chrome/browser/spellchecker/spellcheck_service.cc ('k') | chrome/browser/ui/webui/options/language_options_handler_common.cc » ('j') | chrome/common/chrome_switches.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_service_unittest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_service_unittest.cc b/chrome/browser/spellchecker/spellcheck_service_unittest.cc

index 5d30455befc4524baaa55063c137df89b1bda1b9..b28d7ea3a98855ce9fd105e69c5d09e2333396c2 100644

--- a/chrome/browser/spellchecker/spellcheck_service_unittest.cc

+++ b/chrome/browser/spellchecker/spellcheck_service_unittest.cc

@@ -41,7 +41,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages1) {

std::vector<std::string> languages;

SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(

- accept_languages, "en-US", &languages);

+ accept_languages, &languages);

EXPECT_EQ(1U, languages.size());

EXPECT_EQ("en-US", languages[0]);

@@ -54,7 +54,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages2) {

std::vector<std::string> languages;

SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(

- accept_languages, "en-US", &languages);

+ accept_languages, &languages);

EXPECT_EQ(1U, languages.size());

EXPECT_EQ("en-US", languages[0]);

@@ -68,7 +68,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages3) {

std::vector<std::string> languages;

SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(

- accept_languages, "en-US", &languages);

+ accept_languages, &languages);

EXPECT_EQ(2U, languages.size());

@@ -85,7 +85,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages4) {

std::vector<std::string> languages;

SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(

- accept_languages, "en-US", &languages);

+ accept_languages, &languages);

EXPECT_EQ(2U, languages.size());

@@ -103,7 +103,7 @@ TEST_F(SpellcheckServiceTest, GetSpellCheckLanguages5) {

std::vector<std::string> languages;

SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(

- accept_languages, "fr", &languages);

+ accept_languages, &languages);

EXPECT_EQ(1U, languages.size());

EXPECT_EQ("fr", languages[0]);