Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/spellchecker/spellcheck_service.cc

Index: chrome/browser/spellchecker/spellcheck_service.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service.cc b/chrome/browser/spellchecker/spellcheck_service.cc
index f40924e8c18e3ff48c2c981a1514e2ff5b7ce827..58b04f7310049c9e47cf4491a9ec54751b354e4f 100644
--- a/chrome/browser/spellchecker/spellcheck_service.cc
+++ b/chrome/browser/spellchecker/spellcheck_service.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/spellchecker/spellcheck_service.h"
 
+#include "base/command_line.h"
 #include "base/prefs/pref_member.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_split.h"
@@ -13,6 +14,7 @@
 #include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h"
 #include "chrome/browser/spellchecker/spellcheck_platform_mac.h"
 #include "chrome/browser/spellchecker/spelling_service_client.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/spellcheck_messages.h"
 #include "components/user_prefs/user_prefs.h"
@@ -75,20 +77,32 @@ SpellcheckService::~SpellcheckService() {
 }
 
 // static
-int SpellcheckService::GetSpellCheckLanguages(
-    content::BrowserContext* context,
-    std::vector<std::string>* languages) {
+std::set<int> SpellcheckService::GetSpellCheckLanguages(
+      content::BrowserContext* context,
+      std::vector<std::string>* languages) {
   PrefService* prefs = user_prefs::UserPrefs::Get(context);
-  StringPrefMember accept_languages_pref;
-  StringPrefMember dictionary_language_pref;
-  accept_languages_pref.Init(prefs::kAcceptLanguages, prefs);
-  dictionary_language_pref.Init(prefs::kSpellCheckDictionary, prefs);
-  std::string dictionary_language = dictionary_language_pref.GetValue();
+  std::vector<std::string> dictionary_languages;
+
+  const base::CommandLine* command_line =
+      base::CommandLine::ForCurrentProcess();
+  if (command_line->HasSwitch(switches::kEnableMultilingualSpellChecker)) {
+    StringPrefMember dictionary_languages_pref;

[please use gerrit instead, 2015/02/23 18:51:48]

You can use "dictionary_languages_pref" for both clauses of the if statement.

[Klemen Forstnerič, 2015/02/24 21:57:45]

Done.

+    dictionary_languages_pref.Init(prefs::kSpellCheckDictionaries, prefs);
+

[please use gerrit instead, 2015/02/23 18:51:47]

No need for this newline.

[Klemen Forstnerič, 2015/02/24 21:57:45]

Done.

+    base::SplitString(
+        dictionary_languages_pref.GetValue(), ',', &dictionary_languages);

[please use gerrit instead, 2015/02/23 18:51:47]

You may want to put "static const char kDictionaryLanguagesSeparator = ',';"
into spellcheck_common.h.

[Klemen Forstnerič, 2015/02/24 21:57:45]

Done.

+  } else {
+    StringPrefMember dictionary_language_pref;
+    dictionary_language_pref.Init(prefs::kSpellCheckDictionary, prefs);
+

[please use gerrit instead, 2015/02/23 18:51:47]

No need for this newline.

[Klemen Forstnerič, 2015/02/24 21:57:46]

Done.

+    dictionary_languages.push_back(dictionary_language_pref.GetValue());
+  }
 
-  // Now scan through the list of accept languages, and find possible mappings
-  // from this list to the existing list of spell check languages.
   std::vector<std::string> accept_languages;
 

[please use gerrit instead, 2015/02/23 18:51:48]

No need for this newline.

[Klemen Forstnerič, 2015/02/24 21:57:45]

Done.

+  StringPrefMember accept_languages_pref;
+  accept_languages_pref.Init(prefs::kAcceptLanguages, prefs);
+
 #if defined(OS_MACOSX)
   if (spellcheck_mac::SpellCheckerAvailable())
     spellcheck_mac::GetAvailableLanguages(&accept_languages);
@@ -98,28 +112,26 @@ int SpellcheckService::GetSpellCheckLanguages(
   base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
 #endif  // !OS_MACOSX
 
-  GetSpellCheckLanguagesFromAcceptLanguages(
-      accept_languages, dictionary_language, languages);
+  *languages = dictionary_languages;
+  GetSpellCheckLanguagesFromAcceptLanguages(accept_languages, languages);
 
-  for (size_t i = 0; i < languages->size(); ++i) {
-    if ((*languages)[i] == dictionary_language)
-      return i;
-  }
-  return -1;
+  // Fill the set with the currently selected languages' indices.
+  std::set<int> selected_language_indices;
+  for (std::size_t i = 0; i < dictionary_languages.size(); ++i)

[please use gerrit instead, 2015/02/23 18:51:48]

No need for "std::" before "size_t". If I missed a PSA about us switching to
std::size_t, please let me know.

[Klemen Forstnerič, 2015/02/24 21:57:46]

Done.

+    selected_language_indices.insert(i);

[please use gerrit instead, 2015/02/23 18:51:48]

Add a comment that the the first |dictionary_languages| indices work because the
|languages| array begins with the |dictionary_languages| array.

[Klemen Forstnerič, 2015/02/24 21:57:45]

Done.

+
+  return selected_language_indices;
 }
 
 // static
 void SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
     const std::vector<std::string>& accept_languages,
-    const std::string& dictionary_language,
     std::vector<std::string>* languages) {
-  // The current dictionary language should be there.
-  languages->push_back(dictionary_language);
 
-  for (std::vector<std::string>::const_iterator i = accept_languages.begin();
-       i != accept_languages.end(); ++i) {
+  for (const std::string& accept_language : accept_languages) {

[please use gerrit instead, 2015/02/23 18:51:48]

No need to refactor this. It's not directly related to the goal of your patch.

[Klemen Forstnerič, 2015/02/24 21:57:45]

Done.

     std::string language =
-        chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(*i);
+        chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(
+            accept_language);
     if (!language.empty() &&
         std::find(languages->begin(), languages->end(), language) ==
         languages->end()) {