chrome/browser/spellchecker/spellcheck_service.h - Issue 654653002: Enables the user to select multiple languages for spellchecking (UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_service.h

Issue 654653002: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made functions inline Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc ('K') | « chrome/browser/spellchecker/spellcheck_factory.cc ('k') | chrome/browser/spellchecker/spellcheck_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_service.h

diff --git a/chrome/browser/spellchecker/spellcheck_service.h b/chrome/browser/spellchecker/spellcheck_service.h

index a0b22f8bb40844896c7df633aa1ac82ff8fb950e..71a82e52dc8a2fbc8ad313b9ae4fed3216abe3fa 100644

--- a/chrome/browser/spellchecker/spellcheck_service.h

+++ b/chrome/browser/spellchecker/spellcheck_service.h

@@ -60,14 +60,14 @@ class SpellcheckService : public KeyedService,

// returns the index of the current spell check language in the vector.

// TODO(port): this should take a vector of base::string16, but the

// implementation has some dependencies in l10n util that need porting first.

- static int GetSpellCheckLanguages(content::BrowserContext* context,

- std::vector<std::string>* languages);

+ static std::set<int> GetSpellCheckLanguages(

+ content::BrowserContext* context,

+ std::vector<std::string>* languages);

// Computes a vector of strings which are to be displayed in the context

// menu from |accept_languages| and |dictionary_language|.

static void GetSpellCheckLanguagesFromAcceptLanguages(

const std::vector<std::string>& accept_languages,

- const std::string& dictionary_language,

std::vector<std::string>* languages);

// Signals the event attached by AttachTestEvent() to report the specified