Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/browser/spellchecker/spellcheck_service.h

Issue 654653002: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Temporarily disabled tests, fixed a bug Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_service.h
diff --git a/chrome/browser/spellchecker/spellcheck_service.h b/chrome/browser/spellchecker/spellcheck_service.h
index a0b22f8bb40844896c7df633aa1ac82ff8fb950e..989b2554565bfef29158d227dc315230d04e4d21 100644
--- a/chrome/browser/spellchecker/spellcheck_service.h
+++ b/chrome/browser/spellchecker/spellcheck_service.h
@@ -60,14 +60,14 @@ class SpellcheckService : public KeyedService,
// returns the index of the current spell check language in the vector.
// TODO(port): this should take a vector of base::string16, but the
// implementation has some dependencies in l10n util that need porting first.
- static int GetSpellCheckLanguages(content::BrowserContext* context,
- std::vector<std::string>* languages);
+ static std::set<int> GetSpellCheckLanguages(
+ content::BrowserContext* context,
+ std::vector<std::string>* languages);
// Computes a vector of strings which are to be displayed in the context
// menu from |accept_languages| and |dictionary_language|.
static void GetSpellCheckLanguagesFromAcceptLanguages(
const std::vector<std::string>& accept_languages,
- const std::string& dictionary_language,
std::vector<std::string>* languages);
// Signals the event attached by AttachTestEvent() to report the specified
@@ -127,6 +127,10 @@ class SpellcheckService : public KeyedService,
private:
FRIEND_TEST_ALL_PREFIXES(SpellcheckServiceBrowserTest, DeleteCorruptedBDICT);
+ static std::vector<std::string> GetAcceptLanguages(PrefService* prefs);
+ static std::vector<std::string> GetSpellCheckDictionaryLanguages(
+ PrefService* prefs);
+
// Attaches an event so browser tests can listen the status events.
static void AttachStatusEvent(base::WaitableEvent* status_event);

Powered by Google App Engine
This is Rietveld 408576698