Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h

Issue 654653002: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Temporarily disabled tests, fixed a bug Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h
diff --git a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h
index bd0fa392f7c6ba4c1262dfa3eb2c2168de561116..2bfafbb6f6e73ddcaa209839639f875f6ca97679 100644
--- a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h
+++ b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_
#define CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_
+#include <set>
#include <string>
#include <vector>
@@ -13,6 +14,7 @@
#include "components/renderer_context_menu/render_view_context_menu_observer.h"
#include "ui/base/models/simple_menu_model.h"
+class PrefService;
class RenderViewContextMenuProxy;
// A class that implements the 'spell-checker options' submenu. This class
@@ -32,6 +34,14 @@ class SpellCheckerSubMenuObserver : public RenderViewContextMenuObserver {
virtual void ExecuteCommand(int command_id) override;
private:
+#if !defined(OS_MACOSX)
+ void AddLanguagesAsRadioItems();
+ void AddLanguagesAsCheckItems();
+
+ void UpdateSpellcheckDictionariesWithLanguage(size_t language, PrefService*);
+ void SetLanguageAsSpellcheckDictionary(size_t language, PrefService*);
+#endif // !OS_MACOSX
+
// The interface for adding a submenu to the parent.
RenderViewContextMenuProxy* proxy_;
@@ -43,7 +53,7 @@ class SpellCheckerSubMenuObserver : public RenderViewContextMenuObserver {
// Hunspell spelling submenu.
// The radio items representing languages available for spellchecking.
int language_group_;
- int language_selected_;
+ std::set<int> languages_selected_;
std::vector<std::string> languages_;
#endif // !OS_MACOSX

Powered by Google App Engine
This is Rietveld 408576698