Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/spellchecker/spellcheck_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
 #define CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 38 matching lines @@
     DICT_HUNSPELL,
     DICT_TEXT,
     DICT_UNKNOWN,
   };
 
   explicit SpellcheckService(content::BrowserContext* context);
   ~SpellcheckService() override;
 
   // This function computes a vector of strings which are to be displayed in
   // the context menu over a text area for changing spell check languages. It
-  // returns the index of the current spell check language in the vector.
+  // returns the set of indices of the current spell check languages in the

[groby-ooo-7-16, 2015/03/03 17:54:34]

nit: can you change "in the vector" to "in |languages|"?

+  // vector.
   // TODO(port): this should take a vector of base::string16, but the
   // implementation has some dependencies in l10n util that need porting first.
-  static int GetSpellCheckLanguages(content::BrowserContext* context,
-                                    std::vector<std::string>* languages);
+  static std::set<int> GetSpellCheckLanguages(

[groby-ooo-7-16, 2015/03/03 17:54:34]

Is there a particular reason to make it a set? Would vector do?

+      content::BrowserContext* context,
+      std::vector<std::string>* languages);
 
   // Computes a vector of strings which are to be displayed in the context
   // menu from |accept_languages| and |dictionary_language|.
   static void GetSpellCheckLanguagesFromAcceptLanguages(
       const std::vector<std::string>& accept_languages,
-      const std::string& dictionary_language,
       std::vector<std::string>* languages);
 
   // Signals the event attached by AttachTestEvent() to report the specified
   // event to browser tests. This function is called by this class and its
   // derived classes to report their status. This function does not do anything
   // when we do not set an event to |status_event_|.
   static bool SignalStatusEvent(EventType type);
 
   // Instantiates SpellCheckHostMetrics object and makes it ready for recording
   // metrics. This should be called only if the metrics recording is active.
@@ skipping 74 matching lines @@
   scoped_ptr<SpellcheckCustomDictionary> custom_dictionary_;
 
   scoped_ptr<SpellcheckHunspellDictionary> hunspell_dictionary_;
 
   base::WeakPtrFactory<SpellcheckService> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SpellcheckService);
 };
 
 #endif  // CHROME_BROWSER_SPELLCHECKER_SPELLCHECK_SERVICE_H_