Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 654653002: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reset unneccessary changes. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2179 matching lines...) Expand 10 before | Expand all | Expand 10 after
2190 #endif // defined(OS_MACOSX) 2190 #endif // defined(OS_MACOSX)
2191 #if defined(OS_CHROMEOS) 2191 #if defined(OS_CHROMEOS)
2192 { 2192 {
2193 "disable-timezone-tracking", 2193 "disable-timezone-tracking",
2194 IDS_FLAGS_DISABLE_RESOLVE_TIMEZONE_BY_GEOLOCATION_NAME, 2194 IDS_FLAGS_DISABLE_RESOLVE_TIMEZONE_BY_GEOLOCATION_NAME,
2195 IDS_FLAGS_DISABLE_RESOLVE_TIMEZONE_BY_GEOLOCATION_DESCRIPTION, 2195 IDS_FLAGS_DISABLE_RESOLVE_TIMEZONE_BY_GEOLOCATION_DESCRIPTION,
2196 kOsCrOS, 2196 kOsCrOS,
2197 SINGLE_VALUE_TYPE(chromeos::switches::kDisableTimeZoneTrackingOption) 2197 SINGLE_VALUE_TYPE(chromeos::switches::kDisableTimeZoneTrackingOption)
2198 }, 2198 },
2199 #endif // defined(OS_CHROMEOS) 2199 #endif // defined(OS_CHROMEOS)
2200 #if defined(ENABLE_SPELLCHECK) && (defined(OS_LINUX) || defined(OS_WIN))
please use gerrit instead 2015/02/23 18:51:47 Also OS_CHROMEOS.
Klemen Forstnerič 2015/02/24 21:57:45 Done.
2201 {
2202 "enable-multilingual-spellchecker",
2203 IDS_ENABLE_MULTILINGUAL_SPELLCHECKER_NAME,
2204 IDS_ENABLE_MULTILINGUAL_SPELLCHECKER_DESCRIPTION,
2205 kOsWin | kOsLinux,
please use gerrit instead 2015/02/23 18:51:47 Also kOsCrOS.
Klemen Forstnerič 2015/02/24 21:57:45 Done.
2206 SINGLE_VALUE_TYPE(switches::kEnableMultilingualSpellChecker)
2207 },
2208 #endif // defined(ENABLE_SPELLCHECK) && (defined(OS_LINUX) || defined(OS_WIN))
2200 2209
2201 // NOTE: Adding new command-line switches requires adding corresponding 2210 // NOTE: Adding new command-line switches requires adding corresponding
please use gerrit instead 2015/02/23 18:56:22 You should probably follow this advice.
Klemen Forstnerič 2015/02/24 21:57:44 Acknowledged.
2202 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2211 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2203 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2212 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2204 }; 2213 };
2205 2214
2206 const Experiment* experiments = kExperiments; 2215 const Experiment* experiments = kExperiments;
2207 size_t num_experiments = arraysize(kExperiments); 2216 size_t num_experiments = arraysize(kExperiments);
2208 2217
2209 // Stores and encapsulates the little state that about:flags has. 2218 // Stores and encapsulates the little state that about:flags has.
2210 class FlagsState { 2219 class FlagsState {
2211 public: 2220 public:
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
2769 } 2778 }
2770 2779
2771 const Experiment* GetExperiments(size_t* count) { 2780 const Experiment* GetExperiments(size_t* count) {
2772 *count = num_experiments; 2781 *count = num_experiments;
2773 return experiments; 2782 return experiments;
2774 } 2783 }
2775 2784
2776 } // namespace testing 2785 } // namespace testing
2777 2786
2778 } // namespace about_flags 2787 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698