Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: chrome/browser/spellchecker/spellcheck_service.cc

Issue 654653002: Enables the user to select multiple languages for spellchecking (UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made functions inline Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/spellchecker/spellcheck_service.h" 5 #include "chrome/browser/spellchecker/spellcheck_service.h"
6 6
7 #include "base/command_line.h"
7 #include "base/prefs/pref_member.h" 8 #include "base/prefs/pref_member.h"
8 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
9 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
10 #include "base/synchronization/waitable_event.h" 11 #include "base/synchronization/waitable_event.h"
11 #include "chrome/browser/spellchecker/spellcheck_factory.h" 12 #include "chrome/browser/spellchecker/spellcheck_factory.h"
12 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h" 13 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h"
13 #include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h" 14 #include "chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h"
14 #include "chrome/browser/spellchecker/spellcheck_platform_mac.h" 15 #include "chrome/browser/spellchecker/spellcheck_platform_mac.h"
15 #include "chrome/browser/spellchecker/spelling_service_client.h" 16 #include "chrome/browser/spellchecker/spelling_service_client.h"
17 #include "chrome/common/chrome_switches.h"
16 #include "chrome/common/pref_names.h" 18 #include "chrome/common/pref_names.h"
17 #include "chrome/common/spellcheck_messages.h" 19 #include "chrome/common/spellcheck_messages.h"
18 #include "components/user_prefs/user_prefs.h" 20 #include "components/user_prefs/user_prefs.h"
19 #include "content/public/browser/browser_context.h" 21 #include "content/public/browser/browser_context.h"
20 #include "content/public/browser/browser_thread.h" 22 #include "content/public/browser/browser_thread.h"
21 #include "content/public/browser/notification_service.h" 23 #include "content/public/browser/notification_service.h"
22 #include "content/public/browser/notification_types.h" 24 #include "content/public/browser/notification_types.h"
23 #include "content/public/browser/render_process_host.h" 25 #include "content/public/browser/render_process_host.h"
24 #include "ipc/ipc_platform_file.h" 26 #include "ipc/ipc_platform_file.h"
25 27
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 content::NOTIFICATION_RENDERER_PROCESS_CREATED, 79 content::NOTIFICATION_RENDERER_PROCESS_CREATED,
78 content::NotificationService::AllSources()); 80 content::NotificationService::AllSources());
79 } 81 }
80 82
81 SpellcheckService::~SpellcheckService() { 83 SpellcheckService::~SpellcheckService() {
82 // Remove pref observers 84 // Remove pref observers
83 pref_change_registrar_.RemoveAll(); 85 pref_change_registrar_.RemoveAll();
84 } 86 }
85 87
86 // static 88 // static
87 int SpellcheckService::GetSpellCheckLanguages( 89 std::set<int> SpellcheckService::GetSpellCheckLanguages(
88 content::BrowserContext* context, 90 content::BrowserContext* context,
89 std::vector<std::string>* languages) { 91 std::vector<std::string>* languages) {
90 PrefService* prefs = user_prefs::UserPrefs::Get(context); 92 PrefService* prefs = user_prefs::UserPrefs::Get(context);
93
94 std::vector<std::string> dictionary_languages;
95
96 const CommandLine* command_line = CommandLine::ForCurrentProcess();
97 if (command_line->HasSwitch(switches::kEnableMultilingualSpellChecker)) {
98 StringPrefMember dictionary_languages_pref;
99 dictionary_languages_pref.Init(prefs::kSpellCheckDictionaries, prefs);
100
101 base::SplitString(
102 dictionary_languages_pref.GetValue(), ',', &dictionary_languages);
103 } else {
104 StringPrefMember dictionary_language_pref;
105 dictionary_language_pref.Init(prefs::kSpellCheckDictionary, prefs);
106
107 dictionary_languages.push_back(dictionary_language_pref.GetValue());
108 }
109
110 std::vector<std::string> accept_languages;
111
91 StringPrefMember accept_languages_pref; 112 StringPrefMember accept_languages_pref;
92 StringPrefMember dictionary_language_pref;
93 accept_languages_pref.Init(prefs::kAcceptLanguages, prefs); 113 accept_languages_pref.Init(prefs::kAcceptLanguages, prefs);
94 dictionary_language_pref.Init(prefs::kSpellCheckDictionary, prefs);
95 std::string dictionary_language = dictionary_language_pref.GetValue();
96
97 // Now scan through the list of accept languages, and find possible mappings
98 // from this list to the existing list of spell check languages.
99 std::vector<std::string> accept_languages;
100 114
101 #if defined(OS_MACOSX) 115 #if defined(OS_MACOSX)
102 if (spellcheck_mac::SpellCheckerAvailable()) 116 if (spellcheck_mac::SpellCheckerAvailable())
103 spellcheck_mac::GetAvailableLanguages(&accept_languages); 117 spellcheck_mac::GetAvailableLanguages(&accept_languages);
104 else 118 else
105 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages); 119 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
106 #else 120 #else
107 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages); 121 base::SplitString(accept_languages_pref.GetValue(), ',', &accept_languages);
108 #endif // !OS_MACOSX 122 #endif // !OS_MACOSX
109 123
110 GetSpellCheckLanguagesFromAcceptLanguages( 124 // Put the currently selected languages as first ones on the list
111 accept_languages, dictionary_language, languages); 125 *languages = dictionary_languages;
126 GetSpellCheckLanguagesFromAcceptLanguages(accept_languages, languages);
112 127
113 for (size_t i = 0; i < languages->size(); ++i) { 128 std::set<int> selected_languages;
114 if ((*languages)[i] == dictionary_language) 129 for (size_t i = 0; i < dictionary_languages.size(); ++i)
115 return i; 130 selected_languages.insert(i);
116 } 131 return selected_languages;
117 return -1;
118 } 132 }
119 133
120 // static 134 // static
121 void SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages( 135 void SpellcheckService::GetSpellCheckLanguagesFromAcceptLanguages(
122 const std::vector<std::string>& accept_languages, 136 const std::vector<std::string>& accept_languages,
123 const std::string& dictionary_language,
124 std::vector<std::string>* languages) { 137 std::vector<std::string>* languages) {
125 // The current dictionary language should be there.
126 languages->push_back(dictionary_language);
127
128 for (std::vector<std::string>::const_iterator i = accept_languages.begin(); 138 for (std::vector<std::string>::const_iterator i = accept_languages.begin();
129 i != accept_languages.end(); ++i) { 139 i != accept_languages.end(); ++i) {
130 std::string language = 140 std::string language =
131 chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(*i); 141 chrome::spellcheck_common::GetCorrespondingSpellCheckLanguage(*i);
132 if (!language.empty() && 142 if (!language.empty() &&
133 std::find(languages->begin(), languages->end(), language) == 143 std::find(languages->begin(), languages->end(), language) ==
134 languages->end()) { 144 languages->end()) {
135 languages->push_back(language); 145 languages->push_back(language);
136 } 146 }
137 } 147 }
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 } 318 }
309 319
310 void SpellcheckService::UpdateFeedbackSenderState() { 320 void SpellcheckService::UpdateFeedbackSenderState() {
311 if (SpellingServiceClient::IsAvailable( 321 if (SpellingServiceClient::IsAvailable(
312 context_, SpellingServiceClient::SPELLCHECK)) { 322 context_, SpellingServiceClient::SPELLCHECK)) {
313 feedback_sender_->StartFeedbackCollection(); 323 feedback_sender_->StartFeedbackCollection();
314 } else { 324 } else {
315 feedback_sender_->StopFeedbackCollection(); 325 feedback_sender_->StopFeedbackCollection();
316 } 326 }
317 } 327 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698