Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 654643003: On iOS, give directions rather than a link to Date &Time Settings. (Closed)

Created:
6 years, 2 months ago by palmer
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

On iOS, give directions rather than a link to Date &Time Settings. Unfortunately, it is not possible to link directly to the Date & Time Settings app on iOS. BUG=394993 R=felt@chromium.org, rohitrao@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2d8f8a171040e143f6fe5a96ef9adc20014caf97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
palmer
I don't think we can do any better than this. Let me know what you ...
6 years, 2 months ago (2014-10-13 21:46:44 UTC) #2
pink (ping after 24hrs)
I think this is the best we can do, but rohit should probably weigh in ...
6 years, 2 months ago (2014-10-15 13:26:35 UTC) #4
rohitrao (ping after 24h)
LGTM. We should double-check that these directions get translated using the same translations that iOS ...
6 years, 2 months ago (2014-10-15 13:31:41 UTC) #5
felt
whoops! i looked at this but for some reason did not press the button: lgtm
6 years, 2 months ago (2014-10-15 13:51:39 UTC) #6
felt
On 2014/10/15 13:31:41, rohitrao wrote: > LGTM. We should double-check that these directions get translated ...
6 years, 2 months ago (2014-10-15 13:52:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654643003/1
6 years, 2 months ago (2014-10-15 17:33:54 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-15 19:35:38 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2d8f8a171040e143f6fe5a96ef9adc20014caf97 Cr-Commit-Position: refs/heads/master@{#299753}
6 years, 2 months ago (2014-10-15 20:27:36 UTC) #12
palmer
6 years, 2 months ago (2014-10-15 20:27:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d8f8a171040e143f6fe5a96ef9adc20014caf97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698