Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 654613002: Fix Cronet Version.java build error. (Closed)

Created:
6 years, 2 months ago by mef
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Cronet Version.java build error. Specify direct_dependent_settings for cronet_version target. Committed: https://crrev.com/c54e515c2a2d1357392f5faf003d834333700b00 Cr-Commit-Position: refs/heads/master@{#299332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M components/cronet.gypi View 2 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
mef
Hi, It appears that https://codereview.chromium.org/623403002/ broke cronet build: http://build.chromium.org/p/chromium.fyi/builders/Android%20Cronet%20Builder/builds/4409. This CL fixes that.
6 years, 2 months ago (2014-10-13 15:38:29 UTC) #2
xunjieli
On 2014/10/13 15:38:29, mef wrote: > Hi, > > It appears that https://codereview.chromium.org/623403002/ broke cronet ...
6 years, 2 months ago (2014-10-13 16:08:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654613002/1
6 years, 2 months ago (2014-10-13 16:11:23 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-13 16:11:24 UTC) #7
newt (away)
Thanks for fixing! (The old system was prone to a broken dependency graph; my CL ...
6 years, 2 months ago (2014-10-13 16:35:06 UTC) #8
newt (away)
lgtm
6 years, 2 months ago (2014-10-13 16:36:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654613002/1
6 years, 2 months ago (2014-10-13 17:30:42 UTC) #11
mef
On 2014/10/13 16:35:06, newt wrote: > Thanks for fixing! No problem. > (The old system ...
6 years, 2 months ago (2014-10-13 17:42:30 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 18:41:58 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 18:42:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c54e515c2a2d1357392f5faf003d834333700b00
Cr-Commit-Position: refs/heads/master@{#299332}

Powered by Google App Engine
This is Rietveld 408576698