Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 654593002: base: Add NOTREACHED() for when using a non-supported discardable memory type. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

base: Add NOTREACHED() for when using a non-supported discardable memory type. This adds a NOTREACHED() statement for when a non-supported discardable memory type is used on a platform. BUG=422953 TBR=danakj@chromium.org Committed: https://crrev.com/5e783b2dc9925f3022d8445bde5adc18520af477 Cr-Commit-Position: refs/heads/master@{#299345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M base/memory/discardable_memory_android.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/memory/discardable_memory_linux.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
6 years, 2 months ago (2014-10-13 16:51:20 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 2 months ago (2014-10-13 17:06:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654593002/1
6 years, 2 months ago (2014-10-13 18:59:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 19:33:43 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:34:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e783b2dc9925f3022d8445bde5adc18520af477
Cr-Commit-Position: refs/heads/master@{#299345}

Powered by Google App Engine
This is Rietveld 408576698