Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654573003: Add MinidumpCrashpadInfoWriter and its test (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add MinidumpCrashpadInfoWriter and its test. TEST=minidump_test MinidumpCrashpadInfoWriter.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b8a2f41156eb94fe0f597fecac5d967f1500519a

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -32 lines) Patch
M minidump/minidump.gyp View 3 chunks +5 lines, -0 lines 0 comments Download
A minidump/minidump_crashpad_info_writer.h View 1 chunk +69 lines, -0 lines 0 comments Download
A minidump/minidump_crashpad_info_writer.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A minidump/minidump_crashpad_info_writer_test.cc View 1 1 chunk +155 lines, -0 lines 0 comments Download
M minidump/minidump_simple_string_dictionary_writer_test.cc View 2 chunks +1 line, -32 lines 0 comments Download
A minidump/minidump_string_writer_test_util.h View 1 chunk +42 lines, -0 lines 0 comments Download
A minidump/minidump_string_writer_test_util.cc View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-17 21:45:17 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/654573003/diff/1/minidump/minidump_crashpad_info_writer_test.cc File minidump/minidump_crashpad_info_writer_test.cc (right): https://codereview.chromium.org/654573003/diff/1/minidump/minidump_crashpad_info_writer_test.cc#newcode93 minidump/minidump_crashpad_info_writer_test.cc:93: GetCrashpadInfoStream(file_writer.string(), &crashpad_info, NULL)); nullptr https://codereview.chromium.org/654573003/diff/1/minidump/minidump_string_writer_test_util.h File minidump/minidump_string_writer_test_util.h (right): ...
6 years, 2 months ago (2014-10-17 21:54:13 UTC) #3
Mark Mentovai
https://codereview.chromium.org/654573003/diff/1/minidump/minidump_crashpad_info_writer_test.cc File minidump/minidump_crashpad_info_writer_test.cc (right): https://codereview.chromium.org/654573003/diff/1/minidump/minidump_crashpad_info_writer_test.cc#newcode93 minidump/minidump_crashpad_info_writer_test.cc:93: GetCrashpadInfoStream(file_writer.string(), &crashpad_info, NULL)); Robert Sesek wrote: > nullptr Not ...
6 years, 2 months ago (2014-10-17 22:00:25 UTC) #4
Mark Mentovai
6 years, 2 months ago (2014-10-17 22:00:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b8a2f41156eb94fe0f597fecac5d967f1500519a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698