Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 654543003: Revert of Disabling testConformance in response to test failure (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
jamesr, qyearsley
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Disabling testConformance in response to test failure (patchset #1 id:1 of https://codereview.chromium.org/676893002/) Reason for revert: Build failure. http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/46535 ../mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java:181:error: cannot find symbol @DisabledTest ^ Original issue's description: > Disabling testConformance in response to test failure > > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16405 > > BUG=426564 > R=jamesr@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/ed4f7a78af68cd8dcfea63c899fbaf3dd27716e6 TBR=jamesr@chromium.org,qyearsley@chromium.org NOTREECHECKS=true NOTRY=true BUG=426564 Committed: https://crrev.com/873246335d057971ef54fc7f45548bffa46b3da1 Cr-Commit-Position: refs/heads/master@{#300948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Disabling testConformance in response to test failure
6 years, 2 months ago (2014-10-23 21:15:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654543003/1
6 years, 2 months ago (2014-10-23 21:18:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 21:21:12 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 21:21:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/873246335d057971ef54fc7f45548bffa46b3da1
Cr-Commit-Position: refs/heads/master@{#300948}

Powered by Google App Engine
This is Rietveld 408576698