Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 654533003: Re-enable WebView tests (Closed)

Created:
6 years, 2 months ago by perezju
Modified:
6 years, 2 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable WebView tests These WebView tests were incorrectly disabled. See referenced bugs for further info. BUG=419692, 419690 Committed: https://crrev.com/cacbb988abd330dc6ed4fdcb4ec0a810a0ab744a Cr-Commit-Position: refs/heads/master@{#299449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
perezju
These tests were disabled for WebView, but they shouldn't have. Locally both of these tests ...
6 years, 2 months ago (2014-10-13 12:01:09 UTC) #2
Sami
So someone was confusing the failures from other tests with these? If that's the case, ...
6 years, 2 months ago (2014-10-13 13:04:13 UTC) #3
mkosiba (inactive)
lgtm
6 years, 2 months ago (2014-10-13 16:52:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654533003/1
6 years, 2 months ago (2014-10-14 08:22:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 09:18:42 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 09:19:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cacbb988abd330dc6ed4fdcb4ec0a810a0ab744a
Cr-Commit-Position: refs/heads/master@{#299449}

Powered by Google App Engine
This is Rietveld 408576698