Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 654503002: Script streaming: UTF-8 handling fix. (Closed)

Created:
6 years, 2 months ago by marja
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Script streaming: UTF-8 handling fix. The problem was that there can be several multi-byte UTF-8 characters near the splitting point of the data chunks, and the code didn't handle it properly. This was also the source of crbug.com/417891 - I thought the crash can only happen when V8 is passed invalid UTF-8 data, but it can also happen in the abovementioned case. After the fix, we handle the valid UTF-8 case and also guard against invalid UTF-8 data. R=yangguo@chromium.org BUG=chromium:417891 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/scanner-character-streams.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
yangguo, ptal
6 years, 2 months ago (2014-10-13 08:31:48 UTC) #1
marja
yangguo, ptal
6 years, 2 months ago (2014-10-13 08:31:51 UTC) #2
Yang
On 2014/10/13 08:31:51, marja (ooo until 13th Oct) wrote: > yangguo, ptal lgtm.
6 years, 2 months ago (2014-10-13 08:34:53 UTC) #3
marja
6 years, 2 months ago (2014-10-13 09:02:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698