Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 654463004: Fix bug in aggressive layer cache purging (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix bug in aggressive layer cache purging A picture may possess many layers that get placed in one plot of the atlas. In this case we can only remove the plot from the plotUsage tracking structure when all the layers belonging to the picture in that plot have been removed. Committed: https://skia.googlesource.com/skia/+/225a627ccb15f41efa40750f4244283ef7e8fbf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -4 lines) Patch
M src/gpu/GrLayerCache.h View 1 chunk +30 lines, -2 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 5 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robertphillips
6 years, 1 month ago (2014-10-30 17:58:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654463004/1
6 years, 1 month ago (2014-10-30 18:03:57 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-30 18:03:57 UTC) #5
jvanverth1
lgtm
6 years, 1 month ago (2014-10-30 18:12:32 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:39:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 225a627ccb15f41efa40750f4244283ef7e8fbf0

Powered by Google App Engine
This is Rietveld 408576698