Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 654403002: Convert ARRAYSIZE_UNSAFE -> arraysize in content/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, michaeln, asanka, posciak+watch_chromium.org, creis+watch_chromium.org, tzik, benjhayden+dwatch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, wjia+watch_chromium.org, kinuko+fileapi, jochen+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert ARRAYSIZE_UNSAFE -> arraysize in content/. R=avi@chromium.org BUG=423134 Committed: https://crrev.com/2dfaba7f52620e6cc36e689ae100c304459affc9 Cr-Commit-Position: refs/heads/master@{#299850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -191 lines) Patch
M content/browser/android/java/java_type_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_database.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_database_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/dom_storage/dom_storage_area_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_net_log_parameters.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/download/save_package.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/fileapi/external_mount_points_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_quota_client_unittest.cc View 12 chunks +28 lines, -28 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/isolated_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_unittest.cc View 8 chunks +10 lines, -12 lines 0 comments Download
M content/browser/media/media_internals.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/quota/quota_database_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/quota/quota_manager_unittest.cc View 37 chunks +56 lines, -58 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/multipart_response_delegate_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/test/aes_cbc_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/test/aes_gcm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/test/aes_kw_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/test/rsa_oaep_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/webcrypto/test/rsa_ssa_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/webcrypto/test/test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/address_parser_internal.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/database_identifier_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/common/fileapi/file_system_util_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/sandbox_mac_diraccess_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/shell/renderer/test_runner/mock_grammar_check.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_user_media_client.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/test/mock_keyboard_driver_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
viettrungluu
6 years, 2 months ago (2014-10-16 04:39:46 UTC) #1
Avi (use Gerrit)
Stampity stamp LGTM though I see plenty of opportunities to undo line wrapping where there ...
6 years, 2 months ago (2014-10-16 05:08:48 UTC) #2
viettrungluu
Thanks. On 2014/10/16 05:08:48, Avi wrote: > Stampity stamp LGTM > > though I see ...
6 years, 2 months ago (2014-10-16 05:14:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654403002/1
6 years, 2 months ago (2014-10-16 05:15:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 05:30:35 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 05:31:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dfaba7f52620e6cc36e689ae100c304459affc9
Cr-Commit-Position: refs/heads/master@{#299850}

Powered by Google App Engine
This is Rietveld 408576698