Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654393005: [Chromoting] Update size to use inner/outer bounds (Closed)

Created:
6 years, 2 months ago by garykac
Modified:
6 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Update size to use inner/outer bounds BUG= Committed: https://crrev.com/d5ea2ad0ec6d4e0405fc25863c4ffa15e68be056 Cr-Commit-Position: refs/heads/master@{#301388}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M remoting/webapp/base/js/message_window.js View 1 chunk +7 lines, -2 lines 0 comments Download
M remoting/webapp/js_proto/chrome_proto.js View 2 chunks +16 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
garykac
6 years, 2 months ago (2014-10-24 21:26:51 UTC) #2
Jamie
lgtm https://codereview.chromium.org/654393005/diff/1/remoting/webapp/js_proto/chrome_proto.js File remoting/webapp/js_proto/chrome_proto.js (right): https://codereview.chromium.org/654393005/diff/1/remoting/webapp/js_proto/chrome_proto.js#newcode370 remoting/webapp/js_proto/chrome_proto.js:370: this.innerBounds = null; Didn't this just land in ...
6 years, 2 months ago (2014-10-24 22:33:34 UTC) #3
garykac
https://codereview.chromium.org/654393005/diff/1/remoting/webapp/js_proto/chrome_proto.js File remoting/webapp/js_proto/chrome_proto.js (right): https://codereview.chromium.org/654393005/diff/1/remoting/webapp/js_proto/chrome_proto.js#newcode370 remoting/webapp/js_proto/chrome_proto.js:370: this.innerBounds = null; On 2014/10/24 22:33:33, Jamie wrote: > ...
6 years, 1 month ago (2014-10-27 16:25:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654393005/1
6 years, 1 month ago (2014-10-27 16:27:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 17:16:30 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 17:17:08 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d5ea2ad0ec6d4e0405fc25863c4ffa15e68be056
Cr-Commit-Position: refs/heads/master@{#301388}

Powered by Google App Engine
This is Rietveld 408576698