Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: ui/views/widget/native_widget_mac.mm

Issue 654393002: MacViews: Fix WidgetTest.DesktopNativeWidgetNoPaintAfterCloseTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ReadReceivedPaintAndReset Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/focus/focus_manager.h ('k') | ui/views/widget/widget_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_mac.mm
diff --git a/ui/views/widget/native_widget_mac.mm b/ui/views/widget/native_widget_mac.mm
index c6d851d02cabb275ae8ab30dd02579715af5ce63..b6aa7176a1163772804329ac8577fa0cf8146f31 100644
--- a/ui/views/widget/native_widget_mac.mm
+++ b/ui/views/widget/native_widget_mac.mm
@@ -18,10 +18,15 @@
#include "ui/views/window/native_frame_view.h"
@interface NativeWidgetMacNSWindow : NSWindow
+- (ViewsNSWindowDelegate*)viewsNSWindowDelegate;
@end
@implementation NativeWidgetMacNSWindow
+- (ViewsNSWindowDelegate*)viewsNSWindowDelegate {
+ return base::mac::ObjCCastStrict<ViewsNSWindowDelegate>([self delegate]);
+}
+
// Override canBecome{Key,Main}Window to always return YES, otherwise Windows
// with a styleMask of NSBorderlessWindowMask default to NO.
- (BOOL)canBecomeKeyWindow {
@@ -32,6 +37,15 @@
return YES;
}
+// Override orderWindow to intercept visibility changes, since there is no way
+// to observe these changes via NSWindowDelegate.
+- (void)orderWindow:(NSWindowOrderingMode)orderingMode
+ relativeTo:(NSInteger)otherWindowNumber {
+ [[self viewsNSWindowDelegate] onWindowOrderWillChange:orderingMode];
+ [super orderWindow:orderingMode relativeTo:otherWindowNumber];
+ [[self viewsNSWindowDelegate] onWindowOrderChanged];
+}
+
@end
namespace views {
@@ -301,6 +315,12 @@ void NativeWidgetMac::SetShape(gfx::NativeRegion shape) {
}
void NativeWidgetMac::Close() {
+ if (!bridge_)
+ return;
+
+ // Clear the view early to suppress repaints.
+ bridge_->SetRootView(NULL);
+
NSWindow* window = GetNativeWindow();
// Calling performClose: will momentarily highlight the close button, but
// AppKit will reject it if there is no close button.
« no previous file with comments | « ui/views/focus/focus_manager.h ('k') | ui/views/widget/widget_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698