Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: content/shell/android/BUILD.gn

Issue 654383002: GN: Enable loading libraries from apks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stack-debug
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/android/BUILD.gn
diff --git a/content/shell/android/BUILD.gn b/content/shell/android/BUILD.gn
index 5843b1212b524879af40a8787e3009e69ddeb513..ef3fe61719ada64d4087d689ea591593dbc3d79c 100644
--- a/content/shell/android/BUILD.gn
+++ b/content/shell/android/BUILD.gn
@@ -98,6 +98,7 @@ copy_ex("copy_content_shell_assets") {
android_apk("content_shell_apk") {
use_chromium_linker = true
+ load_library_from_apk = true
rmcilroy 2014/10/21 10:55:45 We don't do this for the content shell APK with gy
cjhopman 2014/10/21 17:28:53 We definitely should be doing this for some target
rmcilroy 2014/10/21 21:21:03 Agreed, I'll take a look at enabling the linker te
testonly = true
datadeps = [
# "//tools/android/forwarder",
@@ -177,6 +178,7 @@ if (cpu_arch != "x64" && cpu_arch != "arm64") {
"//content/public/android:content_java",
"//ui/android:ui_java",
]
+ load_library_from_apk = true
android_manifest = "linker_test_apk/AndroidManifest.xml"
asset_location = content_shell_assets_dir
apk_name = "ChromiumLinkerTest"

Powered by Google App Engine
This is Rietveld 408576698