Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 654363002: Move ExtensionDownloader to //extensions (Closed)

Created:
6 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ExtensionDownloader to //extensions This is a mechanical move with opportunistic clang_format applied for cleanup. This also introduces a dependency on //google_apis within //extensions/browser. BUG=398671 Committed: https://crrev.com/05f40a92987303ac217e68cec183cf9d19ffa290 Cr-Commit-Position: refs/heads/master@{#299957}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -1580 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/external_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/chrome_extension_downloader_factory.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/updater/extension_downloader.h View 1 chunk +0 lines, -334 lines 0 comments Download
D chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +0 lines, -956 lines 0 comments Download
D chrome/browser/extensions/updater/extension_downloader_delegate.h View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/extensions/updater/extension_downloader_delegate.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/browser/updater/extension_downloader.h View 6 chunks +13 lines, -13 lines 0 comments Download
A + extensions/browser/updater/extension_downloader.cc View 31 chunks +100 lines, -84 lines 0 comments Download
A + extensions/browser/updater/extension_downloader_delegate.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + extensions/browser/updater/extension_downloader_delegate.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Ken Rockot(use gerrit already)
Antony could you take a look?
6 years, 2 months ago (2014-10-15 22:55:30 UTC) #2
Ken Rockot(use gerrit already)
James, could you also take a look for //e/b/DEPS? A while back, I looked into ...
6 years, 2 months ago (2014-10-15 23:00:21 UTC) #5
asargent_no_longer_on_chrome
lgtm
6 years, 2 months ago (2014-10-15 23:43:00 UTC) #6
James Cook
DEPS lgtm
6 years, 2 months ago (2014-10-16 16:21:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654363002/10001
6 years, 2 months ago (2014-10-16 16:35:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18074)
6 years, 2 months ago (2014-10-16 16:44:10 UTC) #11
Ken Rockot(use gerrit already)
Woops. +rogerta for //google_apis/gaia OWNERs (adding to //extensions/browser/DEPS)
6 years, 2 months ago (2014-10-16 16:47:59 UTC) #13
Roger Tawa OOO till Jul 10th
lgtm
6 years, 2 months ago (2014-10-16 19:32:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654363002/10001
6 years, 2 months ago (2014-10-16 19:34:19 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:10001)
6 years, 2 months ago (2014-10-16 19:40:35 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:42:01 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05f40a92987303ac217e68cec183cf9d19ffa290
Cr-Commit-Position: refs/heads/master@{#299957}

Powered by Google App Engine
This is Rietveld 408576698