Intorduce PowerButtonObserver API

Intorduce PowerButtonObserver API

renamed existing PowerButtonController to ShutdownDialog

BUG=None
TEST=covered by unit tests

Committed: https://crrev.com/0d921cdf45872ebff6c22da6a21c12d44054a860
Cr-Commit-Position: refs/heads/master@{#299821}

R=mukai@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/a99e783b14fb9f2a2c3c18b43d2ab0ab260377b6

[oshima, 2014-10-15 22:10:49]

Patchset #1 (id:1) has been deleted

[oshima, 2014-10-15 22:26:56]

Patchset #1 (id:20001) has been deleted

[oshima, 2014-10-15 22:28:53]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2014-10-15 22:28:54]

https://codereview.chromium.org/654343002/diff/40001/athena/system/power_butt...
File athena/system/power_button_controller.h (right):

https://codereview.chromium.org/654343002/diff/40001/athena/system/power_butt...
athena/system/power_button_controller.h:24: class PowerButtonController : public
PowerButtonObserver {
This class should probably be renamed to something like ShutdownDialog. I'll
create a separate CL for it.

[Jun Mukai, 2014-10-15 23:38:46]

https://codereview.chromium.org/654343002/diff/40001/athena/input/input_manag...
File athena/input/input_manager_impl.cc (right):

https://codereview.chromium.org/654343002/diff/40001/athena/input/input_manag...
athena/input/input_manager_impl.cc:109: brightness_is_zero_ = (level == 0);
I personally feel that these power-button related methods and fields (like
brightness_is_zero_) would introduce some messiness into InputManagerImpl.

It seems it is better to make a separate class for the handling, and
InputManagerImpl simply owns the new class of power-button handling.

WDYT?

https://codereview.chromium.org/654343002/diff/40001/athena/input/input_manag...
athena/input/input_manager_impl.cc:115: // Ignore power button pressed while the
screen is off (http://crbug.com/128451).
exceeds 80 chars?

https://codereview.chromium.org/654343002/diff/40001/athena/input/input_manag...
File athena/input/input_manager_unittest.cc (right):

https://codereview.chromium.org/654343002/diff/40001/athena/input/input_manag...
athena/input/input_manager_unittest.cc:56:
GetInputManagerImpl()->SetPowerButtonTimeoutMsForTest(10)) {
Can we set the timeout 0 for testing?  10 msec is really short, but I'm still a
bit worried that using timeout could cause flakiness.

[oshima, 2014-10-16 00:13:02]

uploaded new patch. PTAL.

[Jun Mukai, 2014-10-16 00:52:20]

https://codereview.chromium.org/654343002/diff/80001/athena/input/input_manag...
File athena/input/input_manager_unittest.cc (right):

https://codereview.chromium.org/654343002/diff/80001/athena/input/input_manag...
athena/input/input_manager_unittest.cc:75: TEST_F(InputManagerTest, PowerButton)
{
Then can we move this test to power_button_controller_unittests?

[Jun Mukai, 2014-10-16 00:54:01]

lgtm in advance -- if you feel that test should be in input_manager_unittests,
that's fine.

[oshima, 2014-10-16 00:55:49]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-10-16 00:57:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/654343002/80001

[commit-bot: I haz the power, 2014-10-16 02:22:37]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2014-10-16 02:23:11]

Patchset 3 (id:??) landed as
https://crrev.com/0d921cdf45872ebff6c22da6a21c12d44054a860
Cr-Commit-Position: refs/heads/master@{#299821}

[jam, 2014-10-16 04:52:17]

A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/659923002/ by jam@chromium.org.

The reason for reverting is: This is breaking the main waterfall :
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

It appears that athena_unittests got added to the waterfall and not trybots.
Please fix that before relanding this..

[oshima, 2014-10-16 08:52:16]

Patchset #4 (id:100001) has been deleted

[commit-bot: I haz the power, 2014-10-16 10:09:37]

Patchset 5 (id:??) landed as
https://crrev.com/a99e783b14fb9f2a2c3c18b43d2ab0ab260377b6
Cr-Commit-Position: refs/heads/master@{#299873}

[oshima, 2014-10-16 10:09:41]

Committed patchset #5 (id:140001) manually as
a99e783b14fb9f2a2c3c18b43d2ab0ab260377b6 (presubmit successful).