Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 654323003: Revert of Added quota client for serviceworker. Enables 'clear past <time> data'. (Closed)

Created:
6 years, 2 months ago by kareng
Modified:
6 years, 2 months ago
Reviewers:
michaeln, jkarlin, sky, jsbell, dmurph
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Added quota client for serviceworker. Enables 'clear past <time> data'. (patchset #7 id:300001 of https://codereview.chromium.org/633273002/) Reason for revert: causing crashes https://code.google.com/p/chromium/issues/detail?id=424831 Original issue's description: > Added quota client for serviceworker. Enables 'clear past <time> data'. > > BUG=419287 > > Committed: https://crrev.com/f6916df879bf23bacf994880359c980f4249e324 > Cr-Commit-Position: refs/heads/master@{#299918} TBR=michaeln@chromium.org,jsbell@chromium.org,sky@chromium.org,dmurph@chromium.org NOTREECHECKS=true NOTRY=true BUG=419287 Committed: https://crrev.com/10e58e62b3dff1340532cb5986315e7174186497 Cr-Commit-Position: refs/heads/master@{#300251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -344 lines) Patch
M content/browser/service_worker/service_worker_context_core.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 3 chunks +0 lines, -61 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.h View 3 chunks +6 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_context_wrapper.cc View 4 chunks +23 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_database.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D content/browser/service_worker/service_worker_quota_client.h View 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/service_worker/service_worker_quota_client.cc View 1 chunk +0 lines, -95 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M storage/browser/quota/quota_client.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
kareng
Created Revert of Added quota client for serviceworker. Enables 'clear past <time> data'.
6 years, 2 months ago (2014-10-18 01:36:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654323003/1
6 years, 2 months ago (2014-10-18 01:37:34 UTC) #2
commit-bot: I haz the power
Failed to apply patch for storage/browser/quota/quota_client.h: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-10-18 01:38:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654323003/1
6 years, 2 months ago (2014-10-20 12:28:02 UTC) #6
jkarlin
On 2014/10/18 01:38:38, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 2 months ago (2014-10-20 12:28:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 12:28:35 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 12:29:23 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10e58e62b3dff1340532cb5986315e7174186497
Cr-Commit-Position: refs/heads/master@{#300251}

Powered by Google App Engine
This is Rietveld 408576698