Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 654323002: Update closure compiler object type for extension data (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update closure compiler object type for extension data Adds a missing type that was introduced in https://crrev.com/55721c1fd3bb640d29491407572c7dbb56975ca5 Committed: https://crrev.com/ec167b62822fadd0d1b6ba12a64ccc5e10ad4ffd Cr-Commit-Position: refs/heads/master@{#299777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
6 years, 2 months ago (2014-10-15 20:27:49 UTC) #2
not at google - send to devlin
lgtm
6 years, 2 months ago (2014-10-15 20:29:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654323002/1
6 years, 2 months ago (2014-10-15 20:30:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 22:02:49 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 22:03:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec167b62822fadd0d1b6ba12a64ccc5e10ad4ffd
Cr-Commit-Position: refs/heads/master@{#299777}

Powered by Google App Engine
This is Rietveld 408576698