Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 654303004: Add AX role for blockquote tag (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 381
382 if (isHTMLDivElement(node)) 382 if (isHTMLDivElement(node))
383 return DivRole; 383 return DivRole;
384 384
385 if (isHTMLFormElement(node)) 385 if (isHTMLFormElement(node))
386 return FormRole; 386 return FormRole;
387 387
388 if (node && node->hasTagName(articleTag)) 388 if (node && node->hasTagName(articleTag))
389 return ArticleRole; 389 return ArticleRole;
390 390
391 if (node && node->hasTagName(blockquoteTag))
392 return BlockquoteRole;
393
391 if (node && node->hasTagName(mainTag)) 394 if (node && node->hasTagName(mainTag))
392 return MainRole; 395 return MainRole;
393 396
394 if (node && node->hasTagName(navTag)) 397 if (node && node->hasTagName(navTag))
395 return NavigationRole; 398 return NavigationRole;
396 399
397 if (node && node->hasTagName(asideTag)) 400 if (node && node->hasTagName(asideTag))
398 return ComplementaryRole; 401 return ComplementaryRole;
399 402
400 if (node && node->hasTagName(sectionTag)) 403 if (node && node->hasTagName(sectionTag))
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
694 // Anything that is content editable should not be ignored. 697 // Anything that is content editable should not be ignored.
695 // However, one cannot just call node->hasEditableStyle() since that will as k if its parents 698 // However, one cannot just call node->hasEditableStyle() since that will as k if its parents
696 // are also editable. Only the top level content editable region should be e xposed. 699 // are also editable. Only the top level content editable region should be e xposed.
697 if (hasContentEditableAttributeSet()) 700 if (hasContentEditableAttributeSet())
698 return false; 701 return false;
699 702
700 // List items play an important role in defining the structure of lists. The y should not be ignored. 703 // List items play an important role in defining the structure of lists. The y should not be ignored.
701 if (roleValue() == ListItemRole) 704 if (roleValue() == ListItemRole)
702 return false; 705 return false;
703 706
707 if (roleValue() == BlockquoteRole)
708 return false;
709
704 if (roleValue() == DialogRole) 710 if (roleValue() == DialogRole)
705 return false; 711 return false;
706 712
707 if (roleValue() == FigcaptionRole) 713 if (roleValue() == FigcaptionRole)
708 return false; 714 return false;
709 715
710 if (roleValue() == FigureRole) 716 if (roleValue() == FigureRole)
711 return false; 717 return false;
712 718
713 if (roleValue() == DetailsRole) 719 if (roleValue() == DetailsRole)
(...skipping 1660 matching lines...) Expand 10 before | Expand all | Expand 10 after
2374 if (label && label->renderer()) { 2380 if (label && label->renderer()) {
2375 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2381 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2376 result.unite(labelRect); 2382 result.unite(labelRect);
2377 } 2383 }
2378 } 2384 }
2379 2385
2380 return result; 2386 return result;
2381 } 2387 }
2382 2388
2383 } // namespace blink 2389 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698