Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 654263006: X87: Make disassembler string tables read-only. (Closed)

Created:
6 years, 2 months ago by chunyang.dai
Modified:
6 years, 2 months ago
Reviewers:
Weiliang, bnoordhuis
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Make disassembler string tables read-only. port r24672. original commit message: Move them from .data to .rodata. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/x87/disasm-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
chunyang.dai
WL PTAL. thanks
6 years, 2 months ago (2014-10-20 01:09:27 UTC) #2
Weiliang
lgtm
6 years, 2 months ago (2014-10-20 01:58:21 UTC) #3
Weiliang
6 years, 2 months ago (2014-10-20 01:59:45 UTC) #4
Committed as r24710

Powered by Google App Engine
This is Rietveld 408576698